Closed
Bug 1431267
Opened 6 years ago
Closed 6 years ago
Shield about:preferences test fails "Clicking the view studies link opens about:studies"
Categories
(Firefox :: Settings UI, defect)
Firefox
Settings UI
Tracking
()
RESOLVED
FIXED
Firefox 59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: myk, Assigned: myk)
Details
Attachments
(1 file)
943 bytes,
patch
|
mythmon
:
review+
|
Details | Diff | Splinter Review |
Running the tests in browser/extensions/shield-recipe-client/test/browser/browser_about_preferences.js fails "Clicking the view studies link opens about:studies" with "Got about:preferences#privacy, expected about:studies": >TEST-UNEXPECTED-FAIL | browser/extensions/shield-recipe-client/test/browser/browser_about_preferences.js | Clicking the view studies link opens about:studies. - Got about:preferences#privacy, expected about:studies >Stack trace: >chrome://mochikit/content/browser-test.js:test_is:1269 >chrome://mochitests/content/browser/browser/extensions/shield-recipe-client/test/browser/browser_about_preferences.js:testViewStudiesLink:173 The test run also finds an unexpected tab at the end of the test run: >TEST-UNEXPECTED-FAIL | browser/extensions/shield-recipe-client/test/browser/browser_about_preferences.js | Found an unexpected tab at the end of test run: about:studies - It looks like the test expects about:studies to open in the same tab, whereas it actually opens in a new tab. Unlike bug 1430396, this is not a regression from bug 1379338, as it happens on a build from before that landed. Assuming the current behavior is actually the expected behavior, here's a patch that updates the test to look for about:studies in the new tab (and closes that tab afterward).
Attachment #8943446 -
Flags: review?(mcooper)
Comment 1•6 years ago
|
||
Comment on attachment 8943446 [details] [diff] [review] expect about:studies to open in a new tab Review of attachment 8943446 [details] [diff] [review]: ----------------------------------------------------------------- I think the current behavior is expected, and updating the tests to match is a good idea. If nothing else, fixing the tests seems easier than changing the behavior.
Attachment #8943446 -
Flags: review?(mcooper) → review+
Pushed by myk@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4b7ad48ad5e5 expect about:studies to open in a new tab; r=mythmon
Comment 3•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4b7ad48ad5e5
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in
before you can comment on or make changes to this bug.
Description
•