Closed Bug 1431267 Opened 2 years ago Closed 2 years ago

Shield about:preferences test fails "Clicking the view studies link opens about:studies"


(Firefox :: Preferences, defect)

Not set



Firefox 59
Tracking Status
firefox59 --- fixed


(Reporter: myk, Assigned: myk)



(1 file)

Running the tests in browser/extensions/shield-recipe-client/test/browser/browser_about_preferences.js fails "Clicking the view studies link opens about:studies" with "Got about:preferences#privacy, expected about:studies":

>TEST-UNEXPECTED-FAIL | browser/extensions/shield-recipe-client/test/browser/browser_about_preferences.js | Clicking the view studies link opens about:studies. - Got about:preferences#privacy, expected about:studies
>Stack trace:

The test run also finds an unexpected tab at the end of the test run:

>TEST-UNEXPECTED-FAIL | browser/extensions/shield-recipe-client/test/browser/browser_about_preferences.js | Found an unexpected tab at the end of test run: about:studies - 

It looks like the test expects about:studies to open in the same tab, whereas it actually opens in a new tab.  Unlike bug 1430396, this is not a regression from bug 1379338, as it happens on a build from before that landed.

Assuming the current behavior is actually the expected behavior, here's a patch that updates the test to look for about:studies in the new tab (and closes that tab afterward).
Attachment #8943446 - Flags: review?(mcooper)
Comment on attachment 8943446 [details] [diff] [review]
expect about:studies to open in a new tab

Review of attachment 8943446 [details] [diff] [review]:

I think the current behavior is expected, and updating the tests to match is a good idea. If nothing else, fixing the tests seems easier than changing the behavior.
Attachment #8943446 - Flags: review?(mcooper) → review+
Pushed by
expect about:studies to open in a new tab; r=mythmon
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in before you can comment on or make changes to this bug.