Closed Bug 1431295 Opened 2 years ago Closed 2 years ago

Drop 'undef None' macro

Categories

(Core :: General, enhancement)

55 Branch
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: hiro, Assigned: hiro)

Details

Attachments

(4 files)

X11UndefineNone.h guards us well, so we don't need to undef it explicitly.  That's said, there is still one place that I was hit while I was refactoring animation code, that is widget/gtk/nsWindow.h, there also needs X11UndefineNone.h.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba7a9f9d348a5350df0ae62e6a65041b924c6be
Comment on attachment 8943497 [details]
Bug 1431295 - Drop 'undef None' macro in dom/animation/.

https://reviewboard.mozilla.org/r/213828/#review219596
Attachment #8943497 - Flags: review?(boris.chiou) → review+
Comment on attachment 8943498 [details]
Bug 1431295 - Drop 'undef None' macro in dom/.

https://reviewboard.mozilla.org/r/213830/#review219606
Attachment #8943498 - Flags: review?(amarchesini) → review+
Comment on attachment 8943496 [details]
Bug 1431295 - Drop 'undef None' macro in gfx.

https://reviewboard.mozilla.org/r/213826/#review219788
Attachment #8943496 - Flags: review?(botond) → review+
Comment on attachment 8943495 [details]
Bug 1431295 - Include "X11UndefineNone.h" after including gdx.h in nsWindow.h.

https://reviewboard.mozilla.org/r/213824/#review219790
Attachment #8943495 - Flags: review?(botond) → review+
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8fecffa14e4d
Include "X11UndefineNone.h" after including gdx.h in nsWindow.h. r=botond
https://hg.mozilla.org/integration/autoland/rev/e53c7df917c7
Drop 'undef None' macro in gfx. r=botond
https://hg.mozilla.org/integration/autoland/rev/ff8efa46c460
Drop 'undef None' macro in dom/animation/. r=boris
https://hg.mozilla.org/integration/autoland/rev/25d33cd4ed83
Drop 'undef None' macro in dom/. r=baku
You need to log in before you can comment on or make changes to this bug.