Closed Bug 1431333 Opened 2 years ago Closed 2 years ago

Cubeb logging does not work with cubeb-sandox on

Categories

(Core :: Audio/Video: cubeb, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: achronop, Assigned: kinetik)

Details

Attachments

(1 file)

The cubeb logging api needs to be remoted in order to be able to enable cubeb logs from MOZ_LOG env.
Rank: 15
Priority: -- → P2
Assignee: nobody → kinetik
Status: NEW → ASSIGNED
cubeb_set_log_callback doesn't call through the cubeb_ops table, so it's not hooked by the remoting client when remoting is enabled.  Although I'd expect it to also be called on the server side and cause logging to be enabled anyway.  I'll take a look.
Attached patch bug1431333.patchSplinter Review
Fairly simple fix - initialize logging earlier if requested via the env var.  The pref-based logging already works fine because the pref callback runs in every process.  This change makes the env var based logging's behaviour match.

Alex, please feel free to steal the review from Dan if he doesn't get to it before you see it.
Attachment #8943831 - Flags: review?(dglastonbury)
Comment on attachment 8943831 [details] [diff] [review]
bug1431333.patch

Review of attachment 8943831 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8943831 - Flags: review?(dglastonbury) → review+
Pushed by mgregan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b572d99d0feb
Initialize libcubeb logging earlier.  r=kamidphish
https://hg.mozilla.org/mozilla-central/rev/b572d99d0feb
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.