Closed Bug 1431374 Opened 2 years ago Closed 2 years ago

Remove extra white space in permission prompt labels introduced in bug 1369482

Categories

(Firefox :: Site Identity, enhancement, P1)

58 Branch
enhancement

Tracking

()

RESOLVED FIXED
Firefox 59
Tracking Status
firefox58 --- unaffected
firefox59 --- fixed

People

(Reporter: johannh, Assigned: johannh)

References

Details

Attachments

(1 file)

(Quoting Francesco Lodolo [:flod] from bug 1369482 comment #39)
> (In reply to Mark Striemer [:mstriemer] from comment #38)
> > I just checked the webextension install notification and it's phrased as a
> > question "Add <bolded extension name>?" but this adds spaces. I'm guessing
> > the white space between these elements should be removed.
> 
> Interesting, :aryx pointed out that risk since there are new lines in the
> markup, but I didn't notice extra spaces added when I tested the patch. 
> 
> These are the changes after that test, unless I missed it completely the
> first time
> https://reviewboard.mozilla.org/r/170580/diff/8-12/
> 
> I changed the notification string to
> webNotifications.receiveFromSite2=Will you allow-%S-to send notifications?
> 
> And I see spaces indeed, which is going to be a problem for some locales,
> besides the case pointed out in comment 38 for en-US.
> 
> P.S. there's a typo in a comment, 'notifiation'
Attachment #8943575 - Flags: review?(prathikshaprasadsuman)
Attachment #8943575 - Flags: review?(francesco.lodolo)
This is based on the patch in bug 1431320, so please import it on top of that. We'll also have to wait for that one to land, but that shouldn't be a problem.
Depends on: 1431320
Comment on attachment 8943575 [details] [diff] [review]
Remove extra white space in permission prompt labels

Tested again, and it works as expected.
Attachment #8943575 - Flags: review?(francesco.lodolo) → review+
Comment on attachment 8943575 [details] [diff] [review]
Remove extra white space in permission prompt labels

This works as expected. :)
Attachment #8943575 - Flags: review?(prathikshaprasadsuman) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/4be3c1a37b99569d71515cf3820924a2a76ba1d0
Bug 1431374 - Remove extra white space in permission prompt labels. r=flod,prathiksha
https://hg.mozilla.org/mozilla-central/rev/4be3c1a37b99
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in before you can comment on or make changes to this bug.