1431401 - Intermittent bugs/957770-1.svg == bugs/957770-1-ref.svg | image comparison, max difference: 255, number of differing pixels: 872

Status: RESOLVED FIXED

(Testing :: Reftest, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: dluca [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=157118849&repo=mozilla-central

https://queue.taskcluster.net/v1/task/e5Zmd7UwRM2gL5fXEIHilg/runs/0/artifacts/public/test_info//reftest_errorsummary.log

https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/e5Zmd7UwRM2gL5fXEIHilg/runs/0/artifacts/public/test_info//reftest_errorsummary.log&only_show_unexpected=1

Comment 1

[Intermittent Failures Robot]

17 failures in 141 pushes (0.121 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* mozilla-central: 17

Platform breakdown:
* linux64-ccov: 17

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1431401&startday=2018-01-18&endday=2018-01-18&tree=all

Comment 2

[Andrei Ciure[:aciure]]

There are 33 failures related to this bug in the last bug. This is affecting linux64-ccov, opt builds.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

this is a perma fail based on this range:
https://hg.mozilla.org/mozilla-central/pushloghtml?changeset=a9f3d83fec60cc212c5b99673b3b25a2403b5839

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

I am attempting to bisect the range a bit with 9 different pushes:
https://treeherder.mozilla.org/#/jobs?repo=try&author=[e-mail]&fromchange=d28558d20169d6ec392044ce97c54ea7367c6886&tochange=152ed90bbb452d45b7b4872ac1c919de2f12f6c2

when results come in, I can do round 2 and after that completes we should have a single bug to point to.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

ok, it is somewhere in 3 pushes:
	16d1bd6dba91	Emilio Cobos Álvarez — Bug 1430608: Make nsMediaFeatures work with a document, not a pres context. r=heycam
	bec4537b2efd	Emilio Cobos Álvarez — Bug 1429846: Fix slotted invalidation. r=heycam
	1b62dd209727	Emilio Cobos Álvarez — servo: Merge #19790 - style: Work from multiple bugs (from emilio:fix-all-the-bugs); r=heycam,xidorn


I can only get the top push to build (luckily it contains the bottom two), but this is failing.

:emilio- can you help figure out why so many reftests are failing after these 3 patches landed?

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Is it so many reftests? Or so many times this reftest? Is it in some platform in particular?

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

it is a large variety of reftests on linux64 when built for code coverage.

Comment 8

[Emilio Cobos Álvarez [:emilio]]

Ok, so that's fascinating... These are only SVG reftests, and they seem to randomly have or have not antialiasing...

Off-hand I wouldn't have suspected of any of my patches, but I just realized of something... I hate C++, and it's wild that this got into the tree unnoticed, and without any failure or warning.

I suspect the incoming patch will fix this, if not I'll happily investigate more.

Comment 9

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1431401: Initialise mIsSVGGlyphsDocument on the constructor.

Off-hand I wouldn't have suspected of any of my patches, but I just realized of
something... I hate C++, and it's wild that this got into the tree unnoticed,
and without any failure or warning.

I suspect the incoming patch will fix this, if not I'll happily investigate
more.

FWIW the code that this bit replaced was equally uninitialized... I guess it was
wallpapered in any other way.

Review commit: https://reviewboard.mozilla.org/r/214348/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214348/

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8944030 [details]
Bug 1431401: Initialise mIsSVGGlyphsDocument on the constructor.

https://reviewboard.mozilla.org/r/214348/#review220058

Thanks for writing up this patch

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

this patch on try fixes the problem:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a43ea003a971577d0d5a461ad065c910d6cf6ccf

Comment 12

[Intermittent Failures Robot]

39 failures in 65 pushes (0.6 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* mozilla-central: 39

Platform breakdown:
* linux64-ccov: 39

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1431401&startday=2018-01-19&endday=2018-01-19&tree=all

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a651569fe8d
Initialise mIsSVGGlyphsDocument on the constructor. r=jmaher

Comment 14

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/4a651569fe8d

Comment 15

[Intermittent Failures Robot]

72 failures in 657 pushes (0.11 failures/push) were associated with this bug in the last 7 days. 

This is the #10 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **  

Repository breakdown:
* mozilla-central: 72

Platform breakdown:
* linux64-ccov: 72

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1431401&startday=2018-01-15&endday=2018-01-21&tree=all