Closed Bug 1431475 Opened 6 years ago Closed 6 years ago

Make some printing assertions diagnostic ones, so we get crashes on Nightly.

Categories

(Core :: Printing: Output, enhancement)

Product:
Core
Component:
Printing: Output
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox59 --- wontfix
firefox60 --- fixed

People

(Reporter: bobowen, Assigned: bobowen)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Make assertions guarding opening and closing print recording file streams MOZ_DIAGNOSTIC_ASSERTs
1.69 KB, patch
jwatt
: review+
Details | Diff | Splinter Review 
Printing only has some basic tests at the moment, so we still see problems that we actually have assertions for in the code, but they're just never hit in debug tests.

This bug is for specifically making some of the assertions in the opening and closing of the file for recording MOZ_DIAGNOSTIC_ASSERT so we get crashes on Nightly to help diagnose bug 1418238.

We might want to extend this to other assertions within printing, to try and surface other currently hidden bugs.
Attachment #8943712 - Flags: review?(jwatt) → review+
Pushed by bobowencode@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/877e173a9104
Make assertions guarding opening and closing print recording file streams MOZ_DIAGNOSTIC_ASSERTs. r=jwatt
https://hg.mozilla.org/mozilla-central/rev/877e173a9104
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: