Make some printing assertions diagnostic ones, so we get crashes on Nightly.

RESOLVED FIXED in Firefox 60

Status

()

Core
Printing: Output
RESOLVED FIXED
a month ago
17 days ago

People

(Reporter: bobowen, Assigned: bobowen)

Tracking

(Blocks: 1 bug)

Trunk
mozilla60
Points:
---

Firefox Tracking Flags

(firefox59 wontfix, firefox60 fixed)

Details

Attachments

(1 attachment)

Printing only has some basic tests at the moment, so we still see problems that we actually have assertions for in the code, but they're just never hit in debug tests.

This bug is for specifically making some of the assertions in the opening and closing of the file for recording MOZ_DIAGNOSTIC_ASSERT so we get crashes on Nightly to help diagnose bug 1418238.

We might want to extend this to other assertions within printing, to try and surface other currently hidden bugs.
Created attachment 8943712 [details] [diff] [review]
Make assertions guarding opening and closing print recording file streams MOZ_DIAGNOSTIC_ASSERTs
Attachment #8943712 - Flags: review?(jwatt)
Attachment #8943712 - Flags: review?(jwatt) → review+

Comment 3

a month ago
Pushed by bobowencode@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/877e173a9104
Make assertions guarding opening and closing print recording file streams MOZ_DIAGNOSTIC_ASSERTs. r=jwatt

Comment 4

a month ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/877e173a9104
Status: ASSIGNED → RESOLVED
Last Resolved: a month ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
status-firefox59: affected → wontfix
You need to log in before you can comment on or make changes to this bug.