Closed Bug 1431483 Opened 6 years ago Closed 6 years ago

Add a pseudo stack entry with the image request URL for ImageLoader::Notify

Categories

(Core :: Layout: Images, Video, and HTML Frames, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: mstange, Assigned: mstange)

Details

Attachments

(1 file)

Having the URL for ImageLoader::Notify will make it easier to see which image caused display list building when looking at a profile. For example, there's a stack in bug 1429728 comment 1 that would be more useful if it contained the image URL.
Comment on attachment 8943717 [details]
Bug 1431483 - Add a pseudo stack frame with the image URL to ImageLoader::Notify.

https://reviewboard.mozilla.org/r/214108/#review219830

LGTM, thanks!
Attachment #8943717 - Flags: review?(aosmond) → review+
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/16f5b0c6d4b4
Add a pseudo stack frame with the image URL to ImageLoader::Notify. r=aosmond
https://hg.mozilla.org/mozilla-central/rev/16f5b0c6d4b4
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Product: Core → Core Graveyard
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: