1431546 - fetch_crash_data.py does not handle expired API credentials

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Osmose [:osmose, :mkelly]]

When using the fetch_crash_data script to fetch raw crashes from a server (for bootstrapping the local dev environment, for example), if you use an API key that is expired, the returned crashes contain no info and an `error` key explaining the issue. The script does not detect this, and will save the crashes locally, which can cause issues when writing the fetched crashes to S3 and processing them using the other bootstrapping scripts.

Specifically, if undetected, this will result in a PolyStorageError when the processor tries to save the crash to Postgres, claiming that there's no 'submitted_date' key in the crash.

To avoid this, the fetch_crash_data script should probably not save crash data when the API returns a permission error due to an invalid/expired API token.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

I think it should go one step further--the script should state the API key is expired, the user should either remove the API key from configuration or get a new API key, and then halt.

I say that because I'd rather know up front that I need to update my API key and I can't think of a scenario where I'd want the script to continue with a bad API key.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

I just hit this, so I'll fix it now.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 4348: fix bug 1431546 - raise errors on bad API token

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/1a5082fb0b55b543f3401c875457ede876789943
fix bug 1431546 - raise errors on bad API token

If fetch_crash_data is using a bad api token (expired, non-existent, etc)
it should raise that as an error and not continue rather than save the
error it's getting back from Socorro as the raw crash. This makes that so.

https://github.com/mozilla-services/socorro/commit/e95c27daae62c548e31a2fd6bb567b63ea094c95
Merge pull request #4348 from willkg/1431546-expired-key

fix bug 1431546 - raise errors on bad API token