Closed Bug 143171 Opened 22 years ago Closed 18 years ago

ctrl-click on selected theme does not disable uninstall button

Categories

(SeaMonkey :: Themes, defect)

Product:
SeaMonkey
Component:
Themes
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: ajschult784, Unassigned)

Details

Attachments

(1 file, 1 obsolete file)

avoid strict warnings
1.14 KB, patch
Details | Diff | Splinter Review 
If you have the themes pref panel open and ctrl-click the selected theme, it
does not disable the uninstall button.  Trying to click it causes a javascript
error.
Attached patch patch (obsolete) — — Splinter Review 

    
  
Keywords: patch

    
    

    
  
Comment on attachment 82877 [details] [diff] [review]
patch

You're duplicating the declaration of uninstallButton which will create a JS
strict warning. Move the existing declaration out of the if block instead.

        Attachment #82877 -
        Flags: needs-work+

    
    

    
  


  

        Attachment #82877 -
        Attachment is obsolete: true

    
  
Keywords: review

    
    

    
  
still?
Assignee: shliang → nobody
QA Contact: pmac → themes

    
    

    
  
ya, you can't deselect a theme via ctrl-click, but the wrong code is still there.  It should be fixed or removed.

    
    

    
  
except that the whole pref pane is irrelevant on trunk as suiterunner won't use it.

resolving WFM
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → WORKSFORME
Product: Core → SeaMonkey

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: