Closed
Bug 1431723
Opened 6 years ago
Closed 6 years ago
The LCOV rewriter is ignoring URL overrides
Categories
(Testing :: Code Coverage, enhancement)
Testing
Code Coverage
Tracking
(firefox60 fixed)
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: marco, Assigned: marco)
Details
Attachments
(1 file)
|
1.41 KB,
patch
|
chmanchester
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8943928 -
Flags: review?(cmanchester)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8943928 [details] [diff] [review] Patch Review of attachment 8943928 [details] [diff] [review]: ----------------------------------------------------------------- I think this is right, but can you give an example of an input where this is an issue? Is this an issue before the patches from bug 1402539 are applied?
Attachment #8943928 -
Flags: review?(cmanchester) → review+
|
|
Assignee | |
Comment 3•6 years ago
|
||
(In reply to Chris Manchester (:chmanchester) from comment #2) > Comment on attachment 8943928 [details] [diff] [review] > Patch > > Review of attachment 8943928 [details] [diff] [review]: > ----------------------------------------------------------------- > > I think this is right, but can you give an example of an input where this is > an issue? Is this an issue before the patches from bug 1402539 are applied? For example, "chrome://global/content/netError.xhtml". I haven't tested it without the patches from bug 1402539, but I believe it doesn't work anyway. I can test just to be sure.
Pushed by mcastelluccio@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1d7ba82ebb86 Actually use URL overrides in the LCOV rewriter. r=chmanchester
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1d7ba82ebb86
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•