1431773 - Fix icons in Netmonitor running on top of the Launchpad

Status: RESOLVED INVALID

(DevTools :: Netmonitor, enhancement, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

SVG icons are not visible when running the Netmonitor on top of the Launchpad.

There is an exception (for every icon):
Security Error: Content at http://localhost:8000/?react_perf&firefox-tab=child1/tab1 may not load or link to chrome://devtools/skin/images/pause.svg.

We probably need to use InlineSVG/PostCSS + relative path to *.svg files to fix this issue.

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Julian, do you have any experience with InlineSVG?
What's the proper way to fix this?
Or who else could help?

Honza

Comment 2

[Alexandre Poirot [:ochameau]]

(In reply to Jan Honza Odvarko [:Honza] from comment #0)
> We probably need to use InlineSVG/PostCSS + relative path to *.svg files to
> fix this issue.

About relative paths, it seems complicated to switch to relative when I see that:
https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/src/assets/styles/variables.css#45
variables.css and pause.svg are on two different domains:
 chrome://devtools/content/ versus chrome://devtools/skin/

It may be helpful to get rid of chrome://devtools/skin/ as themes have been deprecated in FF57 (as bootstrapped add-ons)
and move all ressources to chrome://devtools/content/

Comment 3

[Julian Descottes [:jdescottes]]

Sorry for not answering here earlier. Given that we dropped launchpad support for netmonitor, I am closing this. Reopen if you feel it could still be useful.