1431778 - CSS 3D panoramic cube has choppy images and crashes

Status: VERIFIED FIXED

(Core :: Graphics: Layers, defect, P3)

Description

[francois]

Attachment: Firefox_Problem3.jpeg

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36

Steps to reproduce:

On Windows, Android Firefox 57.0.4,
1. open page: http://youriguide.com/sample-full
2. drag the panorama (left side of the screen) in any direction (horizontally, vertically, diagonally)



Actual results:

Attached is a screenshot of the cubic panorama viewer where 6 image tiles are placed on sides of a cube and 3D rotation is applied on mouse drag to rotate the cube. 3D transforms are implemented through CSS 3D styles.

While dragging mouse,
  - the panorama shows images chopped.
  - after a while Firefox crashes


Expected results:

The panorama should display a continuous and complete image that doesn't get chopped.

Comment 1

[francois]

This bug is a pressing issue for us. We have gotten some complaints from customers because of this bug.

Comment 2

[francois]

Attachment: Firefox_Problem2.jpeg

Comment 3

[francois]

Attachment: Firefox_Problem.jpeg

Comment 4

[francois]

Attachment: Firefox_Problem4.jpeg

Comment 5

[Marcia Knous [:marcia]]

Francois: Can you please grab the crash report from about:crashes and paste it here? Thanks.

Comment 6

[Alice0775 White]

I can reproduce the graphics glitch on 52esr as well as nightly59.0a1 Windows10, but not on 45esr. So, I think this is a regression.

Comment 7

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=50792e13354b2407e37daa679c2cc8cccead1b4e&tochange=981ea1b8f2e741361eeaa2a42bf3c5fe607471e1

regressed by : Jamie Nicol — Bug 1274991 - Consider ancestor scale transforms when deciding whether to prerender transformed content. r=mstange

Comment 8

[Alice0775 White]

(In reply to Alice0775 White from comment #7)
> Regression window:
> https://hg.mozilla.org/integration/mozilla-inbound/
> pushloghtml?fromchange=50792e13354b2407e37daa679c2cc8cccead1b4e&tochange=981e
> a1b8f2e741361eeaa2a42bf3c5fe607471e1
> 
> regressed by : Jamie Nicol — Bug 1274991 - Consider ancestor scale
> transforms when deciding whether to prerender transformed content. r=mstange

The range is for the graphics glitch. 
(I cannot reproduce the crash though)

Comment 9

[Jamie Nicol [:jnicol]]

I'll look in to this.

Hi Francois. Is this only with hardware acceleration disabled? (Like bug 1431745?) Do you have a link to any of the crash reports?

Comment 10

[francois]

The panoramas being choppy while being rotated occurs both when hardware acceleration is enabled and disabled.
I wasn't able to reproduce the crash on our Windows computers, so I don't have a crash report.
However one of our users says it crashes.

This is what we got from them: 
"iGuide in Firefox is glitching. Images gets cut when moving in the tour and after couple of rotations the browser completely freeze and becomes unresponsive.
Its been awhile that this issue exist.

1. I'm using my custom built desktop, my Laptop which is (Dell XPS 15, 9650) and my Android phone (Sony XZ with Firefox mobile). They all have the same issue.

2. I'm using Windows 10 and Android 7.

3.My computers Firefox versions are 57.0.4 (64 bit). Chrome doesn't have any issue. its only Firefox.

I did disable the Hardware Acceleration which is by default on and it help to at least not freez the browser completely but still the tour is choppy and it froze for few seconds every time I rotate the 360 image."

Comment 11

[Milan Sreckovic [:milan] (needinfo for best results)]

Jamie, is that enough info to proceed?

Comment 12

[Jamie Nicol [:jnicol]]

Sorry this slipped off my radar. I couldn't reproduce the crashes but I do see the images disappearing. I will work on it now.

Comment 13

[Jamie Nicol [:jnicol]]

Attachment: Bug 1431778 - Take 3D transforms in to account when deciding whether content is small enough to be prerendered.

Review commit: https://reviewboard.mozilla.org/r/236038/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/236038/

Comment 14

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8967341 [details]
Bug 1431778 - Take 3D transforms in to account when deciding whether content is small enough to be prerendered.

https://reviewboard.mozilla.org/r/236038/#review242060

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3de9550cefb
Take 3D transforms in to account when deciding whether content is small enough to be prerendered. r=mattwoodrow

Comment 16

[Jamie Nicol [:jnicol]]

The above patch fixes part of the issue. It should be fine with acceleration enabled now. But there's an additional issue with acceleration disabled, so I'm leaving this bug open until it's fixed too.

Comment 17

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/c3de9550cefb

Comment 18

[Jamie Nicol [:jnicol]]

Let's mark this as fixed actually, because bug 1431745 exists for the remaining problem on that page.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

Would it be possible to land an automated test for this?

Comment 20

[Jamie Nicol [:jnicol]]

Yes, I'll do that. Matt, is test_animation_performance_warning.html the best place for that?

Comment 21

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

The website provided in description is not working and I could not reproduce this issue on Fx 57.0.4 using  other CSS 3D panoramic examples.
Could you provide another example? Thank you!

Comment 22

[korya.github]

(In reply to Cristian Comorasu [:CristiComo] from comment #21)
> The website provided in description is not working and I could not reproduce
> this issue on Fx 57.0.4 using  other CSS 3D panoramic examples.
> Could you provide another example? Thank you!

I have just "unlocked" the web page. Please try loading it again.

Comment 23

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

Thank you, [e-mail] !

I reproduced the rendering issues using Fx 57.0.4, on Windows 10 x64.
I can confirm this issue is fixed, I verified using Fx 61.0b4, on Windows 10 x64, Ubuntu 14.04 LTS and mac OS 10.13.5.

Comment 24

[korya.github]

I just tried FirefoxDeveloperEdition 61.0b4 (64bit) on MacOS. The issue with choppy images is still there: https://youtu.be/sGXA4FgcNS4 .

Comment 25

[Matt Woodrow (:mattwoodrow)]

(In reply to Jamie Nicol [:jnicol] from comment #20)
> Yes, I'll do that. Matt, is test_animation_performance_warning.html the best
> place for that?

Yes, I think so! Get Hiro to review any additions to it.

Comment 26

[Ryan VanderMeulen [:RyanVM]]

Jamie, did we ever end up landing a test for this?

Comment 27

[Jamie Nicol [:jnicol]]

No I didn't. I forget the specifics but I couldn't get test_animation_performance_warning to work with scale animations, then it slipped down my todo list.