1431809 - Sandbox MinGW Compilation errors: Missing constants in MinGW

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

0:02.10 /home/tom/Documents/moz/mingw-work/sandbox/security/sandbox/chromium/base/win/windows_version.cc: In constructor ‘base::win::OSInfo::OSInfo()’:
 0:02.10 /home/tom/Documents/moz/mingw-work/sandbox/security/sandbox/chromium/base/win/windows_version.cc:190:12: error: ‘PRODUCT_ENTERPRISE_S’ was not declared in this scope
 0:02.10        case PRODUCT_ENTERPRISE_S:
 0:02.10             ^~~~~~~~~~~~~~~~~~~~
 0:02.10 /home/tom/Documents/moz/mingw-work/sandbox/security/sandbox/chromium/base/win/windows_version.cc:191:12: error: ‘PRODUCT_ENTERPRISE_S_EVALUATION’ was not declared in this scope
 0:02.10        case PRODUCT_ENTERPRISE_S_EVALUATION:
 0:02.10             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 0:02.10 /home/tom/Documents/moz/mingw-work/sandbox/security/sandbox/chromium/base/win/windows_version.cc:192:12: error: ‘PRODUCT_ENTERPRISE_S_N’ was not declared in this scope
 0:02.10        case PRODUCT_ENTERPRISE_S_N:
 0:02.10             ^~~~~~~~~~~~~~~~~~~~~~
> 0:02.10 /home/tom/Documents/moz/mingw-work/sandbox/security/sandbox/chromium/base/win/windows_version.cc:193:12: error: ‘PRODUCT_ENTERPRISE_S_N_EVALUATION’ was not declared in this scope
> 0:02.10        case PRODUCT_ENTERPRISE_S_N_EVALUATION:
> 0:02.10             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~



Jacek can you add these? It seems like they're in mingw-w64-tools/widl/include/winnt.h but not in mingw-w64-headers/include/winnt.h ?

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Also 

 0:02.53 /home/tom/Documents/moz/mingw-work/sandbox/security/sandbox/chromium/sandbox/win/src/acl.cc:98:20: error: ‘ERROR_INVALID_TOKEN’ was not declared in this scope

Comment 2

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Never mind, I can do this; I don't know why I asked; it's so simple.

Comment 3

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Not bumping MinGW in this particular bug as we'll be bumping it over in Bug 1432009

Comment 4

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

I was wrong, we do need to bump here.

Comment 5

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1431809 Bump MinGW version for new Product Constants

Review commit: https://reviewboard.mozilla.org/r/215306/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/215306/

Comment 6

[Nathan Froyd [:froydnj]]

Comment on attachment 8945082 [details]
Bug 1431809 Bump MinGW version for new Product Constants

https://reviewboard.mozilla.org/r/215306/#review220870

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e13c93143e6
Bump MinGW version for new Product Constants r=froydnj

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/4e13c93143e6