Morph flexbox-paint-ordering-3.html into a still-valid test

RESOLVED FIXED in Firefox 59

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(1 attachment)

I just noticed we've still got a reftest marked as "fails" due to bug 874718:
https://dxr.mozilla.org/mozilla-central/source/layout/reftests/flexbox/reftest.list#75

This reftest was from bug 877890 comment 5, and it was verifying that abspos flex children get painted in order of their "order" property (as the spec used to require).  (And at that point in time, we failed to reorder them because their placeholders were getting wrapped in anonymous flex items, and those anonymous flex items didn't have "order" set.)

Anyway -- the spec has changed since then, and now we're *not* supposed to care about "order" on these elements anymore (and indeed we don't).  So the test is requiring the wrong behavior (which is why it still "fails").

I was thinking of just getting rid of this test, but we should probably be sure we're explicitly testing for & requiring the current behavior.  So I'm filing this bug to morph this test back into something valid & move it into w3c-css/submitted/flexbox with our other upstreamed tests.
(Note: I initially represented this as an "hg rename" operation, but enough of the file ended up changing that it didn't end up producing a useful diff [many of the lines were removed/added].  So in the patch I've posed here, it's just a straight "delete the old file / add the new file" operation.)
Comment on attachment 8944107 [details]
Bug 1431856: Replace incorrect/obsolete reftest flexbox-paint-ordering-3.html with a version that has up-to-date expectations.

https://reviewboard.mozilla.org/r/214432/#review220094
Attachment #8944107 - Flags: review?(mats) → review+
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d8118aedb2a4
Replace incorrect/obsolete reftest flexbox-paint-ordering-3.html with a version that has up-to-date expectations. r=mats
https://hg.mozilla.org/mozilla-central/rev/d8118aedb2a4
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.