1431859 - update taskcluster-treeherder to use queue.task or remove scheduler support altogether

Status: RESOLVED FIXED

(Taskcluster :: Services, enhancement)

Description

[Brian Stack [:bstack]]

It appears the only place it is used is [0]. I'm not sure how necessary this is now.

[0]https://github.com/taskcluster/taskcluster-treeherder/blob/master/src/handler.js#L331-L347

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

This is looking at the *reruns*, which the scheduler implements side-by-side with *retries* by re-running tasks when they fail.  So this handles (by ignoring) the case where a task fails but we expect the scheduler to re-run it

So changing this will cause such "rerun" jobs to appear as failed (red), rather than retried (purple, I think).  Johan, am I right in surmising that it wouldn't be the end of the world for releasetasks to display such red jobs?  It's just a display change.

BTW, the major user of task-graph-scheduler is now tc-vcs.  That doesn't report to treeherder, so no risk there.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

https://github.com/taskcluster/taskcluster-treeherder/pull/45

Comment 3

[Johan Lorenzo [:jlorenzo]]

I didn't find anywhere we still use task-graph-scheduler. Mihai pointed out releasetasks stopped its use in bug 1259627. Then, let's remove these lines!

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Oh, right, how could I forget?!