Closed Bug 1431872 Opened 4 years ago Closed 4 years ago

The linux64-ccov and windows64-ccov builds are missing in the fuzzy list

Categories

(Testing :: Code Coverage, enhancement)

Product:
Testing
Component:
Code Coverage
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: marco, Assigned: marco)

Details

Attachments

(1 file, 1 obsolete file)

Patch
4.76 KB, patch
jmaher
: review+
Details | Diff | Splinter Review 
They used to be there, now only the tests are listed.
Apparently this is happening because the run-on-projects for the coverage builds is empty.
Since we want to make the ccov builds run on mozilla-central and try, we should set run-on-projects to be "trunk" and "try".
Attached patch Patch (obsolete) — — Splinter Review
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
Attachment #8951295 - Flags: review?(jmaher)
Attached patch Patch — — Splinter Review
Attachment #8951295 - Attachment is obsolete: true
Attachment #8951295 - Flags: review?(jmaher)
Attachment #8951298 - Flags: review?(jmaher)
Comment on attachment 8951298 [details] [diff] [review]
Patch

Review of attachment 8951298 [details] [diff] [review]:
-----------------------------------------------------------------

this looks right.
Attachment #8951298 - Flags: review?(jmaher) → review+
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2de04e1a46bd
Set run-on-project for Linux and Windows coverage builds. r=jmaher
https://hg.mozilla.org/mozilla-central/rev/2de04e1a46bd
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
I think this made us start to trigger coverage builds on inbound too. I have no idea why.
maybe the tests depend on the build and the tests need to be annotated as well?
(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #8)
> maybe the tests depend on the build and the tests need to be annotated as
> well?

So maybe if we don't remove the lines in taskcluster/taskgraph/transforms/tests.py it will not be triggered on inbound?
Backout by nbeleuzu@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/928f0f09172f
Backed out changeset 2de04e1a46bd on request from marco for running ccov builds also on autoland and inbound. a=backout
Backout by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/841865bb1ee8
Backed out changeset 2de04e1a46bd on request from marco for running ccov builds also on autoland and inbound. a=backout
Backed out on request from marco for running ccov builds also on autoland and inbound.

Backout push: https://hg.mozilla.org/mozilla-central/rev/928f0f09172fae67f6ec00e7a63969f7b28bd12e
Status: RESOLVED → REOPENED
status-firefox60: fixed → ---
Flags: needinfo?(mcastelluccio)
Resolution: FIXED → ---
Target Milestone: mozilla60 → ---
Fixed by bug 1466077.
Flags: needinfo?(mcastelluccio)
Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.