1431902 - target.json artifact contains improper moz_source_repo property

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Kartikaya Gupta (email:[e-mail])]

- Go to https://tools.taskcluster.net/index/artifacts/gecko.v2.mozilla-central.latest.firefox/linux64-st-an-debug which shows the artifacts from the latest static analysis linux64 build.
- Click on the public/build/target.json artifact on the right, this will open the JSON file
- Look at the "moz_source_repo" property value. I would expect it to be something like "https://hg.mozilla.org/mozilla-central/" but instead it looks like a variable substitution gone bad, "MOZ_SOURCE_REPO="

Comment 1

[Steve Fink [:sfink] [:s:]]

Not it. (Static analysis builds are not mine, despite sound a lot like the static rooting hazard analysis builds that *are* mine.) But I'm not a bad person to needinfo anyway, as a peer of the static analysis module.

I'm going to bounce this over to glandium on the basis of https://searchfox.org/mozilla-central/source/toolkit/mozapps/installer/packager.mk#122 which appears to be the origin of this line. He touched it in bug 1247162.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1431902 - Remove spurious MOZ_SOURCE_REPO= after bug 1247162.

Review commit: https://reviewboard.mozilla.org/r/214746/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214746/

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8944584 [details]
Bug 1431902 - Remove spurious MOZ_SOURCE_REPO= after bug 1247162.

https://reviewboard.mozilla.org/r/214746/#review220412

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9ee14d9dace
Remove spurious MOZ_SOURCE_REPO= after bug 1247162. r=chmanchester

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/e9ee14d9dace