Closed
Bug 1431903
Opened 6 years ago
Closed 6 years ago
Remove unused bits from nsIDOMDataChannel
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(1 file)
6.53 KB,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
Can't easily remove the interface itself, but all the methods and attributes can go.
Assignee | ||
Comment 1•6 years ago
|
||
MozReview-Commit-ID: NRfLiNEWPK
Attachment #8944220 -
Flags: review?(continuation)
Comment 2•6 years ago
|
||
Comment on attachment 8944220 [details] [diff] [review] Remove unused methods from nsIDOMDataChannel Review of attachment 8944220 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/base/nsIDOMDataChannel.idl @@ +6,5 @@ > > %{C++ > #ifdef GetBinaryType > // Windows apparently has a #define for GetBinaryType... > #undef GetBinaryType Can you get rid of this undef now that there's no GetBinaryType method?
Attachment #8944220 -
Flags: review?(continuation) → review+
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/df07eaf643a3 Remove unused methods from nsIDOMDataChannel. r=mccr8
Assignee | ||
Comment 4•6 years ago
|
||
> Can you get rid of this undef now that there's no GetBinaryType method?
Looks like I can, yes.
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/df07eaf643a3
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•