Remove unused bits from nsIDOMDataChannel

RESOLVED FIXED in Firefox 59

Status

()

Core
DOM
RESOLVED FIXED
a month ago
a month ago

People

(Reporter: bz, Assigned: bz)

Tracking

unspecified
mozilla59
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(1 attachment)

Can't easily remove the interface itself, but all the methods and attributes can go.
Created attachment 8944220 [details] [diff] [review]
Remove unused methods from nsIDOMDataChannel

MozReview-Commit-ID: NRfLiNEWPK
Attachment #8944220 - Flags: review?(continuation)
Comment on attachment 8944220 [details] [diff] [review]
Remove unused methods from nsIDOMDataChannel

Review of attachment 8944220 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsIDOMDataChannel.idl
@@ +6,5 @@
>  
>  %{C++
>  #ifdef GetBinaryType
>  // Windows apparently has a #define for GetBinaryType...
>  #undef GetBinaryType

Can you get rid of this undef now that there's no GetBinaryType method?
Attachment #8944220 - Flags: review?(continuation) → review+

Comment 3

a month ago
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/df07eaf643a3
Remove unused methods from nsIDOMDataChannel.  r=mccr8
> Can you get rid of this undef now that there's no GetBinaryType method?

Looks like I can, yes.

Comment 5

a month ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/df07eaf643a3
Status: NEW → RESOLVED
Last Resolved: a month ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.