Closed
Bug 1431961
Opened 6 years ago
Closed 6 years ago
browser/components/extensions/test/browser/test-oop-extensions/browser_ext_user_events.js fails after bug 1193394
Categories
(WebExtensions :: General, defect)
WebExtensions
General
Tracking
(firefox59 fixed)
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dc889458d9c94fd40e976c572ff37e7556298307&selectedJob=156294953&filter-searchStr=bc > TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_user_events.js | Test timed out - > TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_user_events.js | no tasks awaiting on messages - Got ["request"], expected [] > TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_user_events.js | Extension left running at test shutdown -
Assignee | ||
Comment 1•6 years ago
|
||
reproduced locally. taking
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•6 years ago
|
||
it stops at this line https://searchfox.org/mozilla-central/rev/b7e3ec2468d42fa59d86c03ec7afeb209813f1d4/browser/components/extensions/test/browser/browser_ext_user_events.js#55 > await check("page action click");
Assignee | ||
Comment 3•6 years ago
|
||
the extension first shows page action, and then sends page-action-shown message to test, and then adds the event listener. the test waits for the page-action-shown message, and then clicks it. I think the extension should send the message after adding event listener
Assignee | ||
Comment 4•6 years ago
|
||
As mentioned in comment #3, the test should wait for the entire code in `background` function finishes, otherwise the event handler might not be added before clicking page action. So, instead of sending page-action-shown message after showing page action, now it sends actions-ready message after preparing everything (page action, browser action, context menu), and the test waits for the message before starting the actual test for those UI parts.
Attachment #8944223 -
Flags: review?(kmaglione+bmo)
Assignee | ||
Updated•6 years ago
|
Component: General → WebExtensions: General
Product: Firefox → Toolkit
Updated•6 years ago
|
Attachment #8944223 -
Flags: review?(kmaglione+bmo) → review+
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f4d39b4580a1 Wait for the extension startup code before starting tests in browser/components/extensions/test/browser/browser_ext_user_events.js r=kmag
Assignee | ||
Comment 6•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f4d39b4580a145dbeebac275f0edf93f7f69b07a Bug 1431961 - Wait for the extension startup code before starting tests in browser/components/extensions/test/browser/browser_ext_user_events.js r=kmag
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f4d39b4580a1
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Updated•6 years ago
|
Flags: qe-verify-
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•