Closed Bug 1431961 Opened 2 years ago Closed 2 years ago

browser/components/extensions/test/browser/test-oop-extensions/browser_ext_user_events.js fails after bug 1193394

Categories

(WebExtensions :: General, defect)

defect
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(1 file)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dc889458d9c94fd40e976c572ff37e7556298307&selectedJob=156294953&filter-searchStr=bc
> TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_user_events.js | Test timed out - 
> TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_user_events.js | no tasks awaiting on messages - Got ["request"], expected []
> TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_user_events.js | Extension left running at test shutdown -
reproduced locally.
taking
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
the extension first shows page action, and then sends page-action-shown message to test, and then adds the event listener.
the test waits for the page-action-shown message, and then clicks it.

I think the extension should send the message after adding event listener
As mentioned in comment #3, the test should wait for the entire code in `background` function finishes,
otherwise the event handler might not be added before clicking page action.

So, instead of sending page-action-shown message after showing page action,
now it sends actions-ready message after preparing everything (page action, browser action, context menu),
and the test waits for the message before starting the actual test for those UI parts.
Attachment #8944223 - Flags: review?(kmaglione+bmo)
Component: General → WebExtensions: General
Product: Firefox → Toolkit
Attachment #8944223 - Flags: review?(kmaglione+bmo) → review+
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f4d39b4580a1
Wait for the extension startup code before starting tests in browser/components/extensions/test/browser/browser_ext_user_events.js r=kmag
https://hg.mozilla.org/integration/mozilla-inbound/rev/f4d39b4580a145dbeebac275f0edf93f7f69b07a
Bug 1431961 - Wait for the extension startup code before starting tests in browser/components/extensions/test/browser/browser_ext_user_events.js r=kmag
https://hg.mozilla.org/mozilla-central/rev/f4d39b4580a1
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Flags: qe-verify-
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.