Closed Bug 1431965 Opened 4 years ago Closed 4 years ago

Stop using nsIDOMAttr in JS code

Categories

(Calendar :: General, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bzbarsky, Assigned: mschroeder)

References

Details

Attachments

(1 file)

I plan to remove nsIDOMAttr in bug 1431964.

Calendar uses it in two places in calendar/base/modules/calXMLUtils.jsm, both times as:

  next instanceof Components.interfaces.nsIDOMAttr

You should be able to replace those with:

  ChromeUtils.getClassName(next) == "Attr"
Assignee: nobody → mschroeder
Status: NEW → ASSIGNED
Attached patch Patch v1Splinter Review
This is a potential, but untested patch for the issue raised.
Attachment #8944246 - Flags: review?(philipp)
Philipp, can you get to the review here, since bug 1431964 has been landed for 59 already, so we would need this patch for fully a working calendar view in the upcoming beta.
Comment on attachment 8944246 [details] [diff] [review]
Patch v1

Review of attachment 8944246 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, sorry for the delay. Tested this in the browser console and it seems to work fine for attributes. r=philipp
Attachment #8944246 - Flags: review?(philipp)
Attachment #8944246 - Flags: review+
Attachment #8944246 - Flags: approval-calendar-beta+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/598844f28f16
Stop using nsIDOMAttr in JS code. r=philipp
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 6.2
You need to log in before you can comment on or make changes to this bug.