1432017 - Remove AccessibleCaretEventHub::PostScrollState.

Status: RESOLVED FIXED

(Core :: DOM: Selection, enhancement, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

From TYLin in #gfx:

10:37 <TYLin> emilio: have you try to fix the AccessibleCaret stuff yet? I should know everything about it. The LaunchScrollEndInjector() was written when we need to hide the carets when user is scrolling,  but we no longer do that.
10:43 <TYLin> emilio: I feel we could eliminate AccessibleCaretEventHub's PostScrollState because that state exists just to avoid carets flickering when the momentum scroll is still going, and the user lifts the finger off the screen and then scroll again

I want the fix for bug 1431474 to land first since it feels less risky, but let's do that afterwards.

Comment 1

[Jet Villegas (inactive)]

[ Triage 2017/02/20: P3 ]

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1432017 - Remove AccessibleCaretEventHub::PostScrollState.

In the era of B2G, we wanted to hide the carets during scrolling, and
PostScrollState was designed to avoid carets flicking during momentum
scrolling.

These days, we no longer hide carets during scrolling, so PostScrollState
can be removed to make the code simpler and easier to maintain.

Review commit: https://reviewboard.mozilla.org/r/222680/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/222680/

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e5f5aae11972748fd557de013ee37dbdc7b931d0

Comment 4

[Mats Palmgren (inactive)]

Comment on attachment 8953544 [details]
Bug 1432017 - Remove AccessibleCaretEventHub::PostScrollState.

https://reviewboard.mozilla.org/r/222680/#review228852

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d48195c9d3e1
Remove AccessibleCaretEventHub::PostScrollState. r=mats

Comment 6

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/d48195c9d3e1