1432045 - Text vertical alignment on title bar with non-latin characters mix

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P3)

Description

[Daniele "Mte90" Scasciafratte]

Attachment: Screenshot_20180121_183244.png

As you can see in the screenshot, if you are looking on a page that in the title tag contain non-latin characters (in this kind Hindi I guess) and contain latin characters the vertical alignment instead to be on bottom (like for the others) is not on the top.

A page to test: https://addons.mozilla.org/en-US/firefox/addon/swecha/

This bug happen with Firefox Nightly 59.

I am not sure if happen also on other systems but seems more a rendering issue.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1432045 - Maintain consistent alignment in case of font fallback for non-Latin characters.

as suggested in https://bugzilla.mozilla.org/show_bug.cgi?id=1409615#c4

Review commit: https://reviewboard.mozilla.org/r/214836/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214836/

Comment 3

[:Gijs (he/him)]

Comment on attachment 8944680 [details]
Bug 1432045 - Maintain consistent alignment in case of font fallback for non-Latin characters.

https://reviewboard.mozilla.org/r/214836/#review220680

Tentative r=me in that this wfm when testing on macOS

I'm a little concerned about this and bug 1402368 using slightly different constants here, and as far as I can tell, in both cases they're basically eyeballed to be "right". In a way, it feels like we should share them, but on the other hand I guess on Windows (and maybe Linux?) we use radically different font sizes for the url bar vs. tabs so maybe that doesn't make sense. In any case, it's kinda unfortunate that we have to fix it this way and there isn't some kind of vertical-align: baseline or whatever that helps here... Perhaps it's worth talking to the gfx text-y folks like jfkthame if there are more structural solutions we can use?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b529d05259c5
Maintain consistent alignment in case of font fallback for non-Latin characters. r=Gijs

Comment 5

[Dão Gottwald [:dao]]

(In reply to :Gijs (lower availability until Jan 27) from comment #3)
> Comment on attachment 8944680 [details]
> Bug 1432045 - Maintain consistent alignment in case of font fallback for
> non-Latin characters.
> 
> https://reviewboard.mozilla.org/r/214836/#review220680
> 
> Tentative r=me in that this wfm when testing on macOS
> 
> I'm a little concerned about this and bug 1402368 using slightly different
> constants here, and as far as I can tell, in both cases they're basically
> eyeballed to be "right". In a way, it feels like we should share them, but
> on the other hand I guess on Windows (and maybe Linux?) we use radically
> different font sizes for the url bar vs. tabs so maybe that doesn't make
> sense. In any case, it's kinda unfortunate that we have to fix it this way
> and there isn't some kind of vertical-align: baseline or whatever that helps
> here... Perhaps it's worth talking to the gfx text-y folks like jfkthame if
> there are more structural solutions we can use?

jfkthame, any further thoughts on this? See also bug 1409615 comment 4.

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b529d05259c5

Comment 7

[Jonathan Kew [:jfkthame]]

(In reply to Dão Gottwald [::dao] from comment #5)
> jfkthame, any further thoughts on this? See also bug 1409615 comment 4.

Not really. AFAICT something like vertical-align doesn't have any effect here. Given the potential for very different font sizes and relative ascent/descent, especially when font fallback kicks in for an "obscure" character that isn't supported by the main UI font, I think all we can do is to aim for what looks right, and try to avoid designs where text is tightly boxed so that if an unusually tall or deep glyph occurs, it'll run out of room. In general, the line height and vertical extent of UI elements needs to be substantially larger than nominal font size to minimize the risk of such issues; but of course making it too large may look bad for the usual case where there's just simple Latin text. So it's a balancing act...

Comment 8

[B.J. Herbison]

I tested with https://addons.mozilla.org/en-US/firefox/addon/swecha/ on Firefox 58.0 and today's Nightly 60.0a1. The problem exists on Firefox 58, but fixed (and looks much better) on Nightly 60. Tested with Ubuntu.

[bugday-20180131]

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 8944680 [details]
Bug 1432045 - Maintain consistent alignment in case of font fallback for non-Latin characters.

Approval Request Comment
[Feature/Bug causing the regression]: unclear. it's possible that this regressed with photon in 57.
[User impact if declined]: see comment 0
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: fairly simple fix, baked in Nightly for two weeks
[String changes made/needed]: /

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8944680 [details]
Bug 1432045 - Maintain consistent alignment in case of font fallback for non-Latin characters.

Simple fix, taking for 59b8.

Comment 11

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a2cd586a63ec

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.