Closed Bug 1432062 Opened 3 years ago Closed 3 years ago

Require dangling commas via eslint for the migration component

Categories

(Firefox :: Migration, enhancement, P4)

Product:
Firefox
Component:
Migration
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: MattN, Assigned: samreadingthompsondevelopment, Mentored)

References

(
URL
)

Details

Attachments

(1 file)

1432062.patch
20.69 KB, patch
MattN
: review+
Details | Diff | Splinter Review 
In browser/components/migration/.eslintrc.js use:
> "comma-dangle": ["error", "always-multiline"],

Run
> ./mach lint --fix browser/components/migration/

Run
> ./mach test browser/components/migration/

Ensure there are no failures.
Attached patch 1432062.patch — — Splinter Review
Attachment #8944570 - Flags: review?(MattN+bmo)
Attachment #8944570 - Flags: review?(MattN+bmo) → review+
Keywords: checkin-needed
Assignee: MattN+bmo → samreadingthompsondevelopment
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/be32299523e6
Require dangling commas via eslint for the migration component. r=MattN
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/be32299523e6
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in before you can comment on or make changes to this bug.