Closed
Bug 1432062
Opened 7 years ago
Closed 7 years ago
Require dangling commas via eslint for the migration component
Categories
(Firefox :: Migration, enhancement, P4)
Firefox
Migration
Tracking
()
RESOLVED
FIXED
Firefox 60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: MattN, Assigned: samreadingthompsondevelopment, Mentored)
References
()
Details
Attachments
(1 file)
|
20.69 KB,
patch
|
MattN
:
review+
|
Details | Diff | Splinter Review |
In browser/components/migration/.eslintrc.js use:
> "comma-dangle": ["error", "always-multiline"],
Run
> ./mach lint --fix browser/components/migration/
Run
> ./mach test browser/components/migration/
Ensure there are no failures.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8944570 -
Flags: review?(MattN+bmo)
|
Reporter | |
Updated•7 years ago
|
Attachment #8944570 -
Flags: review?(MattN+bmo) → review+
|
|
Reporter | |
Updated•7 years ago
|
Keywords: checkin-needed
|
|
Reporter | |
Updated•7 years ago
|
Assignee: MattN+bmo → samreadingthompsondevelopment
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/be32299523e6
Require dangling commas via eslint for the migration component. r=MattN
Keywords: checkin-needed
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in
before you can comment on or make changes to this bug.
Description
•