1432070 - [Form Autofill] Manage and Edit dialogs show web page contextmenu on right click

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, defect)

Description

[Ian Moody [:Kwan] (UTC+0)]

STR:
1) Open either "Saved Addresses…" or "Saved Credit Cards…" dialogs
1b) [Optional] Open either of "Add…" or "Edit…" dialogs
2) Right click anywhere

ER:
nothing
(or text-specific commands: Undo|Cut/Copy/Paste/Delete|Select All if on a text input in the edit dialogs)

AR:
web page context menu is shown

Unfortunately there's not a perfect solution here I don't think.  It's very easy to stop the contextmenu entirely, but then that loses the textcontrol options.
Can keep the menu around just for text fields, but in addition to the desired editing controls it also has the "This Frame" submenu and "Inspect Element" item.
Main preference fields get their menu from XBL https://searchfox.org/mozilla-central/rev/e9a067a401e41017766f4ab90bc3906603273d51/toolkit/content/widgets/textbox.xml#404
I think the only way to get the same behaviour on these fields would be re-implementing the entire menu manually.

Will attach a patch with the keep-on-input-fields solution.

Comment 1

[Ian Moody [:Kwan] (UTC+0)]

Attachment: Bug 1432070 - Block context menu in Autofill preference dialogs, except on text fields.

The context menu shown is the standard web page one, and so inappropriate for
inside preferences.  Keep it on text fields so text editing commands are still
available, though unfortunately so are "This Frame", "Inspect Element", and
"Add a Keyword for this Search".

Review commit: https://reviewboard.mozilla.org/r/214544/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214544/

Comment 2

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8944318 [details]
Bug 1432070 - Block context menu in Autofill preference dialogs, except on text fields.

https://reviewboard.mozilla.org/r/214544/#review221932

Hi Ian, Thanks for patching this. For some reason, I've been being inactive for a while so I'm afraid I can't review your patch any time soon. Would you mind asking someone else in the team for help? Thanks and sorry for the inconvenience.

Comment 3

[Ian Moody [:Kwan] (UTC+0)]

Comment on attachment 8944318 [details]
Bug 1432070 - Block context menu in Autofill preference dialogs, except on text fields.

https://reviewboard.mozilla.org/r/214544/#review221932

No problem Luke, thanks for the heads up!

Comment 4

[Matthew N. [:MattN]]

Comment on attachment 8944318 [details]
Bug 1432070 - Block context menu in Autofill preference dialogs, except on text fields.

https://reviewboard.mozilla.org/r/214544/#review222622

Comment 5

[Scott Wu [:scottwu]]

Comment on attachment 8944318 [details]
Bug 1432070 - Block context menu in Autofill preference dialogs, except on text fields.

https://reviewboard.mozilla.org/r/214544/#review222940

lgtm, thanks!

Comment 6

[Ian Moody [:Kwan] (UTC+0)]

Thanks Scott and Matt!

Sheriff I don't have a try for this since it seemed too trivial to waste the resources on, and there really shouldn't be any tests this should affect.
Feel free to disagree :)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f784eac344d2
Block context menu in Autofill preference dialogs, except on text fields. r=MattN,scottwu

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/f784eac344d2