Closed Bug 1432104 Opened 6 years ago Closed 6 years ago

Need specialization for KeyframeUtils::GetAnimationPropertiesFromKeyframes

Categories

(Core :: DOM: Animation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: hiro, Assigned: hiro)

References

Details

Attachments

(1 file)

While I am working on bug 1415780, I've been suffering from a linker error. To be honest, I did not read the linker error message carefully since it spews mangling names so it's hard to read at first glance.  So I've been thinking the error was caused by new code I am writing.  But..

Finally I read the error message, it's due to KeyframeUtils::GetAnimationPropertiesFromKeyframes. :/

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fb94d589fd2ce3d7c286f56413aa84397387f94b
Comment on attachment 8944360 [details]
Bug 1432104 - KeyframeUtils::GetAnimationPropertiesFromKeyframes needs specializations both for GeckoStyleContext* and const ServoStyleContext*.

https://reviewboard.mozilla.org/r/214574/#review220410
Attachment #8944360 - Flags: review?(bbirtles) → review+
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2b890d81a1e3
KeyframeUtils::GetAnimationPropertiesFromKeyframes needs specializations both for GeckoStyleContext* and const ServoStyleContext*. r=birtles
https://hg.mozilla.org/mozilla-central/rev/2b890d81a1e3
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Depends on: 1435669
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: