1432106 - document) When title contains '?' encoded as '_' -> language selection always reseted.

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Wiki pages, enhancement)

Description

[junthus]

:: Developer Documentation Request

      Request Type: Correction
     Gecko Version: unspecified
 Technical Contact: 

:: Details

The issue is about title encoding.
"What are extensions?" encoded to `What_are_extensions_`.
For English users, It isn't problem (default redirect to en page) but languages users, NOT. Language selection is always initialized. It's annoying.

Plz fix it.
Thanks.

Comment 1

[junthus]

Attachment: 스크린샷 2018-01-22 18.46.06.png

Comment 2

[Will Bamberg [:wbamberg]]

Yes, so:

https://developer.mozilla.org/en-US/Add-ons/WebExtensions/What_are_WebExtensions_

redirects to:

https://developer.mozilla.org/en-US/Add-ons/WebExtensions/What_are_WebExtensions

but:

https://developer.mozilla.org/ko/Add-ons/WebExtensions/What_are_WebExtensions_

...does not redirect. The link in the sidebar on, say, https://developer.mozilla.org/ko/Add-ons/WebExtensions, is https://developer.mozilla.org/ko/docs/Mozilla/Add-ons/WebExtensions/What_are_WebExtensions_ , which is 404.

I'm reassigning this to MDN platform, but let me know if there are any content-side fixes I can try.

I wonder if it would work just to remove the underscore at the end of the href, here:

https://github.com/mdn/kumascript/blob/master/macros/AddonSidebar.ejs#L23

Comment 3

[John Whitlock [:jwhitlock]]

I agree, changing the macro to switch from a redirect to the target page is the best option. I've opened https://github.com/mdn/kumascript/pull/563 to do this. It appears the page translations already omit the underscore, so there shouldn't be any pages to move in other locales.

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mdn/kumascript

https://github.com/mdn/kumascript/commit/87178642790896127da5bffab238117ceb7e4c90
bug 1432106:AddonSidebar: Update link

https://developer.mozilla.org/en-US/Add-ons/WebExtensions/What_are_WebExtensions_

is now a redirect to:

https://developer.mozilla.org/en-US/Add-ons/WebExtensions/What_are_WebExtensions

The question mark "?" was encoded as an underscore, so it was removed
from the slug.

https://github.com/mdn/kumascript/commit/b74c7f4b8c058191e371f86031766e0b8553f77a
Merge pull request #563 from jwhitlock/addonssidebar-1432106

bug 1432106: AddonSidebar: Update link

Comment 5

[John Whitlock [:jwhitlock]]

The update shipped, and the 1726 pages using AddonSidebar have been re-rendered. Translations should avoid the trailing underscore in the slug, like the English doc does.