1432135 - Rename TokenKind::{Lp,Lc,Lb,...}

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[Jan de Mooij [:jandem]]

Bug 1427710 made TokenKind an enum class. It would be nice to rename TokenKind::Lp/Lc/Lb to TokenKind::LeftParen/LeftCurly/LeftBracket.

Comment 1

[Thi Huynh]

Attachment: Bug 1432135 - Rename TokenKind::{Lb,Rb,Lc,Rc,Lp,Rp} to their long names. r?jandem

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 9002501 [details]
Bug 1432135 - Rename TokenKind::{Lb,Rb,Lc,Rc,Lp,Rp} to their long names. r?jandem

Jan de Mooij [:jandem] has approved the revision.

Comment 3

[Jan de Mooij [:jandem]]

NI to make sure we land this. It's a great patch but it will bitrot quickly :)

Comment 4

[Thi Huynh]

(In reply to Jan de Mooij [:jandem] from comment #3)
> NI to make sure we land this. It's a great patch but it will bitrot quickly
> :)

Sorry but what should I do now?

Comment 5

[Jan de Mooij [:jandem]]

(In reply to Thi Huynh from comment #4)
> Sorry but what should I do now?

Have you checked this compiles locally or do you have Try commit access?

Comment 6

[Thi Huynh]

(In reply to Jan de Mooij [:jandem] from comment #5)
> (In reply to Thi Huynh from comment #4)
> > Sorry but what should I do now?
> 
> Have you checked this compiles locally or do you have Try commit access?

Yes I have checked compiling the code locally (haven't run the tests). I don't have try access though :) .

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2102f887e46b
Rename TokenKind::{Lb,Rb,Lc,Rc,Lp,Rp} to their long names. r=jandem

Comment 8

[Jan de Mooij [:jandem]]

(In reply to Thi Huynh from comment #6)
> Yes I have checked compiling the code locally (haven't run the tests). I
> don't have try access though :) .

OK I asked Lando to land this. Thanks again!

Comment 9

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/2102f887e46b