1432160 - push notification system does not work with geckoview open

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

STR:

1. Login and install a webapp that uses push notifications on fennec nightly 59.  Like telegram or twitter.
2. Close the installed webapp.
3. Launch fennec nightly 59 and open https://gauntface.github.io/simple-push-demo/
4. Select "enable push notifications", accept the permission prompt, and click "send a push via xhr".
5. Observe that a push notification is received.
6. Use the tab switcher to kill fennec.
7. Launch the installed webapp from (1).
8. Repeat steps 3 and 4.
9. Observe that the simple-push-demo cannot enable push notifications.  The UI element stays greyed out.

It seems like there is something broken with permissions or the push notification service if geckoview is started before the main browser.

Another effect from this is you basically don't receive push notifications while a geckoview installed webapp is running.  I noticed this after my wife thought I was ignoring her telegram messages.

James, do you have anyone who could look into this?

Comment 1

[Jovan Gerodetti]

bkelly: you should also know that telegram, due to a bug, goes offline when idle and ignores push messages. https://github.com/zhukov/webogram/issues/1602

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

(In reply to Jovan Gerodetti from comment #1)
> bkelly: you should also know that telegram, due to a bug, goes offline when
> idle and ignores push messages.
> https://github.com/zhukov/webogram/issues/1602

Thanks, but that seems unrelated to comment 0.  I can reproduce using twitter and not using telegram at all.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Jim, can you please investigate?

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Any luck here?  I basically can't use our installed PWA support right now because of this.  I worry about it getting visibility without our marketing push around PWAs shipping.

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

I can spend some time on this today.

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1432160 - Initialize PushService for custom tabs / PWA;

We currently initialize PushService on delayed startup, which only
happens when Fennec is launched. This patch makes us also initialize
PushService if needed by web content from custom tabs / PWA, by
listening for the push initialization event in GeckoApplication.

Review commit: https://reviewboard.mozilla.org/r/218956/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/218956/

Comment 7

[Ben Kelly [:bkelly, not reviewing]]

Is there a bug to get mochitest/WPT tests running in geckoview?

Comment 8

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8949579 [details]
Bug 1432160 - Initialize PushService for custom tabs / PWA;

https://reviewboard.mozilla.org/r/218956/#review224824

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4fbfcf77891
Initialize PushService for custom tabs / PWA; r=snorp

Comment 10

[(inactive) Jim Chen [:jchen] [:darchons]]

I think this is enough to fix the bug, but please reopen if not

Comment 11

[Ben Kelly [:bkelly, not reviewing]]

Can this be uplifted to beta?  Also, I'm really worried we don't have test coverage for this stuff since we're marketing the install-to-homescreen support.

Comment 12

[Andreas Bovens [:abovens]]

That seems like a good idea. Let me check with Ritu.

Comment 13

[(inactive) Jim Chen [:jchen] [:darchons]]

Yeah should be upliftable once it lands in central

Comment 14

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/b4fbfcf77891

Comment 15

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b4fbfcf77891

Comment 16

[Oana Horvath [:ohorvath]]

Verified as fixed on the latest Nightly build (2018-02-12).
Device: Sony Xperia Z5 Premium (Android 6.0.1)

Comment 17

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8949579 [details]
Bug 1432160 - Initialize PushService for custom tabs / PWA;

Approval Request Comment
[Feature/Bug causing the regression]: N/A
[User impact if declined]: Unable to use web push when custom tab / PWA is open
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: Slightly
[Why is the change risky/not risky?]: The patch initializes web push for cases where we didn't before -- when using custom tab /PWA; it's possible but unlikely this can introduce regressions
[String changes made/needed]: None

Comment 18

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8949579 [details]
Bug 1432160 - Initialize PushService for custom tabs / PWA;

Product team (abovens) would like this uplifted to 59, fix has been verified on Nightly, Beta59+

Comment 19

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/31a1ad5257ec

Comment 20

[u549602]

Verified as fixed on the latest Beta build, 59.0b11.

This issue was verified using a Sony Xperia Z3 - Android 5.1.1