1432166 - another ghost window on washingtonpost.com

Status: RESOLVED INCOMPLETE

(Core :: DOM: Core & HTML, defect, P3)

Description

[Ben Kelly [:bkelly, not reviewing]]

Attachment: memory-report.json.gz

I found another ghost window on washingtonpost.com today.  Running 59.0a1 (2018-01-15) (64-bit):

│   ├──19.87 MB (10.02%) -- top(none)/ghost
│   │  ├──16.04 MB (08.09%) ++ window(https://www.washingtonpost.com/)
│   │  └───3.83 MB (01.93%) -- (6 tiny)
│   │      ├──1.34 MB (00.67%) ++ window(https://imasdk.googleapis.com/js/core/bridge3.188.1_en.html#goog_344509202)
│   │      ├──1.34 MB (00.67%) ++ window(https://imasdk.googleapis.com/js/core/bridge3.188.1_en.html#goog_905141335)
│   │      ├──0.70 MB (00.35%) ++ window(https://cdn.krxd.net/partnerjs/xdi/proxy.3d2100fd7107262ecb55ce6847f01fa5.html#!kxcid=IbWIJ0xh&kxt=https%3A%2F%2Fwww.washingtonpost.com&kxcl=cdn&kxp=)
│   │      ├──0.22 MB (00.11%) ++ window(about:blank)
│   │      ├──0.14 MB (00.07%) ++ window(https://tpc.googlesyndication.com/sodar/6uQTKQJz.html)
│   │      └──0.10 MB (00.05%) ++ window(about:srcdoc)

The cc logs reports more nsGlobalWindowInner objects than this, though:

cc-edges.13488.1516630865.log:000001F483998400 [rc=978] nsGlobalWindowInner # 6442452347 inner https://www.washingtonpost.com/
cc-edges.13488.1516630865.log:000001F487E34000 [rc=28] nsGlobalWindowInner # 6442452369 inner https://www.washingtonpost.com/
cc-edges.13488.1516630865.log:000001F4809A6400 [rc=26] nsGlobalWindowInner # 6442452367 inner https://www.washingtonpost.com/
cc-edges.13488.1516630865.log:000001F482F75800 [rc=26] nsGlobalWindowInner # 6442452368 inner https://www.washingtonpost.com/
cc-edges.13488.1516630865.log:000001F489CE4C00 [rc=18] nsGlobalWindowInner # 6442452355 inner https://cdn.krxd.net/partnerjs/xdi/proxy.3d2100fd7107262ecb55ce6847f01fa5.html#!kxcid=IbWIJ0xh&kxt=https%3A%2F%2Fwww.washingtonpost.com&kxcl=cdn&kxp=
cc-edges.13488.1516630865.log:000001F480E8E800 [rc=4] nsGlobalWindowInner # 6442452385 inner https://www.washingtonpost.com/
cc-edges.13488.1516630865.log:000001F482F42800 [rc=4] nsGlobalWindowInner # 6442452373 inner https://www.washingtonpost.com/
cc-edges.13488.1516630865.log:000001F488AAB800 [rc=4] nsGlobalWindowInner # 6442452349 inner https://www.washingtonpost.com/
cc-edges.13488.1516630865.log:000001F489FB6000 [rc=1] nsGlobalWindowInner # 6442452361 inner https://www.washingtonpost.com/
cc-edges.13488.1516630865.log:000001F489FB7800 [rc=1] nsGlobalWindowInner # 6442452363 inner https://www.washingtonpost.com/
cc-edges.13488.1516630865.log:000001F489FB5400 [rc=1] nsGlobalWindowInner # 6442452360 inner https://www.washingtonpost.com/

The cdn.krxd.net window is leaked via:

000001F4E17B5580 [FragmentOrElement (xhtml) script https://www.washingtonpost.com/]
    --[mNodeInfo]--> 000001F4D2E1B780 [NodeInfo (xhtml) script]
    --[mOwnerManager]--> 000001F4DF6B6EB0 [nsNodeInfoManager]
    --[mDocument]--> 000001F4E06E4000 [nsDocument normal (xhtml) https://www.washingtonpost.com/]
    --[Preserved wrapper]--> 000001F4F94D6F10 [JS Object (HTMLDocument)]
    --[group_global]--> 000001F4E5A809C0 [JS Object (Window)]
    --[UnwrapDOMObject(obj)]--> 000001F480E8E800 [nsGlobalWindowInner # 6442452385 inner https://www.washingtonpost.com/]
    --[mTopInnerWindow]--> 000001F483998400 [nsGlobalWindowInner # 6442452347 inner https://www.washingtonpost.com/]
    --[Preserved wrapper]--> 000001F4E4BAE100 [JS Object (Window)]
    --[Krux]--> 000001F4F9C05BC0 [JS Object (Function - t)]
    --[require]--> 000001F4F9C1E500 [JS Object (Function - t.exports)]
    --[fun_environment]--> 000001F4808CC040 [JS Object (Call)]
    --[n]--> 000001F4EFA64400 [JS Object (Function - __webpack_require__)]
    --[c]--> 000001F4EFA4C060 [JS Object (Object)]
    --[objectElements[61]]--> 000001F4E6C7EFE0 [JS Object (Object)]
    --[unboxed_object]--> 000001F4D96717E0 [JS Object (Object)]
    --[client]--> 000001F4DA976080 [JS Object (Function - e.client)]
    --[fun_environment]--> 000001F48081CCE0 [JS Object (Call)]
    --[c]--> 000001F4E1FCA600 [JS Object (Object)]
    --[broker]--> 000001F4E1FCA560 [JS Object (Object)]
    --[window]--> 000001F4E670E9C0 [JS Object (Proxy)]
    --[proxy target]--> 000001F4E670E840 [JS Object (Proxy)]
    --[group_global, proxy target]--> 000001F4E4BAE6A0 [JS Object (Window)]
    --[UnwrapDOMObject(obj)]--> 000001F489CE4C00 [nsGlobalWindowInner # 6442452355 inner https://cdn.krxd.net/partnerjs/xdi/proxy.3d2100fd7107262ecb55ce6847f01fa5.html#!kxcid=IbWIJ0xh&kxt=https%3A%2F%2Fwww.washingtonpost.com&kxcl=cdn&kxp=]

    Root 000001F4E17B5580 is a ref counted object with 1 unknown edge(s).
    known edges:
       000001F4D3D6D480 [FragmentOrElement (xhtml) head https://www.washingtonpost.com/] --[mAttrsAndChildren[i]]--> 000001F4E17B5580

The first washingtonpost.com window is leaked via:

000001F4E17B5580 [FragmentOrElement (xhtml) script https://www.washingtonpost.com/]
    --[mNodeInfo]--> 000001F4D2E1B780 [NodeInfo (xhtml) script]
    --[mOwnerManager]--> 000001F4DF6B6EB0 [nsNodeInfoManager]
    --[mDocument]--> 000001F4E06E4000 [nsDocument normal (xhtml) https://www.washingtonpost.com/]
    --[Preserved wrapper]--> 000001F4F94D6F10 [JS Object (HTMLDocument)]
    --[group_global]--> 000001F4E5A809C0 [JS Object (Window)]
    --[UnwrapDOMObject(obj)]--> 000001F480E8E800 [nsGlobalWindowInner # 6442452385 inner https://www.washingtonpost.com/]
    --[mTopInnerWindow]--> 000001F483998400 [nsGlobalWindowInner # 6442452347 inner https://www.washingtonpost.com/]

    Root 000001F4E17B5580 is a ref counted object with 1 unknown edge(s).
    known edges:
       000001F4D3D6D480 [FragmentOrElement (xhtml) head https://www.washingtonpost.com/] --[mAttrsAndChildren[i]]--> 000001F4E17B5580

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

It seems like "[FragmentOrElement (xhtml) script" with one unknown edge is a recurring theme lately.

Comment 2

[Marcos Caceres [:marcosc]]

Hi Ben, :farre and I were doing triage but were unsure how to proceed with this or how bad it is. Worth prioritizing more?

Comment 3

[Marion Daly [:mdaly]]

(In reply to Marcos Caceres [:marcosc] from comment #2)
> Hi Ben, :farre and I were doing triage but were unsure how to proceed with
> this or how bad it is. Worth prioritizing more?

It's part of the larger meta for nsGlobalWindow leaks, as this affects only one site it seems I'm going to set this to p3 major as a candidate to work on in the future.

Comment 4

[Andrew McCreight [:mccr8]]

We can just mark this incomplete and reopen it if it is a problem. (I'm actually seeing a lot of ghost windows in my local sessions, but I'll file a new bug for that...)