1432177 - Upgrade Firefox 60 to use NSS 3.36

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement, P1)

Description

[Franziskus Kiefer [:franziskus]]

Tracking NSS 3.36 for Firefox 60.

Comment 1

[Franziskus Kiefer [:franziskus]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b206a2ce5351c46419807a8167a07b5311cb3647

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/348b36156a84
land NSS 10f7e0179b18 UPGRADE_NSS_RELEASE, r=me
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c8bbd57b772
bump NSS version in old-configure.in

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/348b36156a84
https://hg.mozilla.org/mozilla-central/rev/1c8bbd57b772

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ed6f573553e7
land NSS 1b20549e1075 UPGRADE_NSS_RELEASE, r=me

Comment 5

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/ed6f573553e7

Comment 6

[Kai Engert (:KaiE:)]

Try run looks good to me:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=15c071733a3b682c8c44aae0b850be9a3073f5c6

I'll uplift an equivalent beta3 snapshot to m-i.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3aea87ef84e9
uplift NSS_3_36_BETA3, r=me

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3aea87ef84e9

Comment 9

[Milan Sreckovic [:milan] (needinfo for best results)]

I can't build on Windows 10 anymore:
38:10.29 c:/Users/Milan/Repos/mozilla-central/security/nss/lib/freebl/verified/Hacl_Chacha20_Vec128.c(229): error C2719: 'v3': formal parameter with requested alignment of 16 won't be aligned
38:10.30 mozmake.EXE[4]: *** [c:/Users/Milan/Repos/mozilla-central/config/rules.mk:774: Hacl_Chacha20_Vec128.obj] Error 2
38:10.30 mozmake.EXE[3]: *** [c:/Users/Milan/Repos/mozilla-central/config/recurse.mk:73: security/nss/lib/freebl/freebl_hw-acc-crypto/target] Error 2

Comment 10

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Franziskus would have a better idea of the underlying issue here.

Comment 11

[Franziskus Kiefer [:franziskus]]

Hm, what exactly is the setup you use to build? I just tried it on Windows 10 x64 with VS2017 and that worked fine.
The issue you are seeing is that __m128i have to have an alignment of 16. But I wouldn't expect that to be an issue here (and didn't see it anywhere yet).

Comment 12

[Jorg K (CEST = GMT+2)]

(In reply to Milan Sreckovic [:milan] from comment #9)
Filed bug 1442554 for that. It would be a VS2015 build. Please direct further question to me in the mentioned bug.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7ced88e883e9
land NSS_3_36_RTM, r=franziskus

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7ced88e883e9

Comment 15

[Jakub Jelen]

FYI, this change is breaking loading PKCS#11 modules in Firefox:

https://bugzilla.mozilla.org/show_bug.cgi?id=1447628