Upgrade Firefox 60 to use NSS 3.36

RESOLVED FIXED in Firefox 60

Status

()

enhancement
P1
normal
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: franziskus, Assigned: franziskus)

Tracking

unspecified
Future
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox60 fixed)

Details

(Whiteboard: [psm-assigned])

Tracking NSS 3.36 for Firefox 60.
Priority: -- → P1
Whiteboard: [psm-assigned]
Depends on: 1433644
Pushed by franziskuskiefer@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ed6f573553e7
land NSS 1b20549e1075 UPGRADE_NSS_RELEASE, r=me
Assignee: franziskuskiefer → nobody
See Also: → 1432480
No longer depends on: 1440588
Try run looks good to me:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=15c071733a3b682c8c44aae0b850be9a3073f5c6

I'll uplift an equivalent beta3 snapshot to m-i.
I can't build on Windows 10 anymore:
38:10.29 c:/Users/Milan/Repos/mozilla-central/security/nss/lib/freebl/verified/Hacl_Chacha20_Vec128.c(229): error C2719: 'v3': formal parameter with requested alignment of 16 won't be aligned
38:10.30 mozmake.EXE[4]: *** [c:/Users/Milan/Repos/mozilla-central/config/rules.mk:774: Hacl_Chacha20_Vec128.obj] Error 2
38:10.30 mozmake.EXE[3]: *** [c:/Users/Milan/Repos/mozilla-central/config/recurse.mk:73: security/nss/lib/freebl/freebl_hw-acc-crypto/target] Error 2
Flags: needinfo?(dkeeler)
Assignee: nobody → franziskuskiefer
Franziskus would have a better idea of the underlying issue here.
Flags: needinfo?(dkeeler) → needinfo?(franziskuskiefer)
Hm, what exactly is the setup you use to build? I just tried it on Windows 10 x64 with VS2017 and that worked fine.
The issue you are seeing is that __m128i have to have an alignment of 16. But I wouldn't expect that to be an issue here (and didn't see it anywhere yet).
Flags: needinfo?(franziskuskiefer) → needinfo?(milan)
Depends on: 1442554
(In reply to Milan Sreckovic [:milan] from comment #9)
Filed bug 1442554 for that. It would be a VS2015 build. Please direct further question to me in the mentioned bug.
Flags: needinfo?(milan)
Keywords: leave-open
https://hg.mozilla.org/mozilla-central/rev/7ced88e883e9
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
FYI, this change is breaking loading PKCS#11 modules in Firefox:

https://bugzilla.mozilla.org/show_bug.cgi?id=1447628
Depends on: 1461731
You need to log in before you can comment on or make changes to this bug.