1432193 - Firefox 58 - lost all passwords, sync disconnected

Status: RESOLVED DUPLICATE of bug 1295122

(Firefox :: Sync, defect)

Description

[Joshua Nixon]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20180118215408

Steps to reproduce:

After update to Firefox 58, sync was disconnected when browser opened. Reconnecting worked, but passwords are not syncing.


Actual results:

Sync reports as expected. Connection data shows browser is syncing, account data shows me all connected computers. Some data (e.g. saved addresses/bookmarks/history) was present on system. However no saved logins exist for Fx 58, whereas a computer running Fx 57 (signed in to same account) shows hundreds of saved logins. Manually refreshing sync does not fix, nor does restarting either browser. Bidirectional issue as well - Sync of newly saved passwords does not occur regardless of which browser version password cache is updated (Fx 58 <-> Fx 57).


Expected results:

Unclear what happened here. If Fx 58 profile is not backwards-compatible (per some items I have seen on Fx support), and this specifically impacts logins, users need some sort of warning. If I didn't have an external password manager I would have been severely impacted by this. At minimum update to Fx 58 should WARN prior to running or have a working method of importing all saved logins BEFORE update. If I lose the password cache for one of my systems (one where I do NOT have ability to install an external password manager) I will be locked out of some critical sites.

Comment 1

[Lina Butler [:lina]]

This sounds a lot like bug 1295122, which we've seen many times, but unable to reproduce or explain. :-( I'm sorry.

Do you see any error logs in about:sync-log, and, if so, do any of them mention passwords or errors like "TypeError: Services.logins is undefined"? Would you mind following the instructions in https://wiki.mozilla.org/Toolkit:Password_Manager/Debugging, then checking the browser console for errors, particularly for anything mentioning "crypto-SDR.js"?

Also, if you open your Firefox profile folder (about:support > Profile Folder), do you see a logins.json (or logins.json.corrupt) file? Does it look like logins.json contains valid login records, like this: https://gist.github.com/kitcambridge/47a05b5e5b9a8d0642892cc64228c243 Are there any blank `encryptedUsername` and `encryptedPassword` fields?

Comment 2

[Joshua Nixon]

about:sync-log does contain errors. The WrappedLock exception seems to occur in all. Example:

1516482631622	Sync.Service	DEBUG	User-Agent: Firefox/58.0 (Intel Mac OS X 10.13) FxSync/1.60.0.20180118215408.desktop
1516482631622	Sync.Service	INFO	Starting sync at 2018-01-20 15:10:31 in browser session QY4R0o9ijbUx
1516482631622	Sync.Service	DEBUG	In sync: should login.
1516482631622	Sync.Service	INFO	Logging in the user.
1516482631623	Sync.Status	DEBUG	Status.service: error.login.failed => success.status_ok
1516482631623	Sync.SyncScheduler	DEBUG	Clearing sync triggers and the global score.
1516482631623	Sync.ErrorHandler	ERROR	Sync encountered a login error
1516482631627	Sync.Service	DEBUG	Exception calling WrappedLock: Error: User needs to re-authenticate (resource://services-sync/browserid_identity.js:236:29) JS Stack trace: ensureLoggedIn@browserid_identity.js:236:29 < [e-mail]:834:15 < [e-mail]:173:27 < [e-mail]:129:22 < [e-mail]:99:22 < [e-mail]:853:12 < sync/<@service.js:1082:21 < [e-mail]:99:22 < [e-mail]:1078:12
1516482631629	Sync.Service	DEBUG	Not syncing: login returned false.

logins.json looks fine; nothing else in there (no "corrupt" file present).

Do not see any entry for crypto-SDR.js in the debugging info.

Comment 3

[Joshua Nixon]

For what it's worth: I unchecked the "remember passwords" option, signed out of sync, restarted browser, signed in again, checked the "remember passwords" button one more time. That restored everything back to normal.

So at least there is a relatively easy solution to the issue, BUT doesn't help explain why it broke. Thanks.

Comment 4

[Mark Hammond [:markh] [:mhammond]]

As Kit mentioned, this is almost certainly Firefox losing all your passwords for reasons we don't understand. Fortunately, in your case, they were "just" lost with no ongoing issue re storing new ones - which isn't always the case. Either way, I'll mark this as a dupe of bug 1295122, which we hope to implement remediation for soon.