Closed Bug 1432232 Opened 4 years ago Closed 4 years ago

Implement 'prefix' support on the new console

Categories

(DevTools :: Console, enhancement, P1)

enhancement

Tracking

(firefox59 wontfix, firefox60 fixed)

RESOLVED FIXED
Firefox 60
Tracking Status
firefox59 --- wontfix
firefox60 --- fixed

People

(Reporter: bgrins, Assigned: nchevobbe)

References

Details

(Whiteboard: [newconsole-mvp])

Attachments

(1 file)

In the browser console, messages be prefixed with custom strings. For example, run: `./mach run --setpref browser.uiCustomization.debug=true --jsconsole` and see the messages prefixed with "CustomizableUI:".

In this bug we'll need to add some stubs with a prefix, implement the frontend changes to render it, support filtering on the string, and write some tests (ideally in mocha tests with the stubs).
Priority: -- → P2
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment on attachment 8953123 [details]
Bug 1432232 - Implement prefix support in new console frontend; .

https://reviewboard.mozilla.org/r/222378/#review228316

Really nice!
Attachment #8953123 - Flags: review?(bgrinstead) → review+
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d8ffc9e58ff1
Implement prefix support in new console frontend; r=bgrins.
Backed out for failing mochitest devtools failures at devtools/client/webconsole/new-console-output/test/fixtures/stub-generators/browser_webconsole_check_stubs_console_api.js

Push that contains the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=2e44a7285ccddce48e794db74ce59cd98fd1ae9f

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=163742100&repo=autoland&lineNumber=17303

Backout: https://hg.mozilla.org/integration/autoland/rev/fca4d1626c28bafb2764b7288522511f63aac98f
Flags: needinfo?(nchevobbe)
https://hg.mozilla.org/mozilla-central/rev/d8ffc9e58ff1
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
How did this hit m-c?  It was backed out on autoland in https://hg.mozilla.org/integration/autoland/rev/fca4d1626c28bafb2764b7288522511f63aac98f.

The changeset in autoland is marked as backed out https://hg.mozilla.org/integration/autoland/rev/d8ffc9e58ff1 but the backout doesn't appear in m-c: https://hg.mozilla.org/mozilla-central/rev/fca4d1626c28bafb2764b7288522511f63aac98f.
Flags: needinfo?(aciure)
We are aware of this issue and we will add the backout in the next merge.
Flags: needinfo?(aciure)
Sorry, hit the wrong button in mozreview
Flags: needinfo?(nchevobbe)
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/58c8931ca290
Implement prefix support in new console frontend; r=bgrins.
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.