1432232 - Implement 'prefix' support on the new console

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Brian Grinstead [:bgrins]]

In the browser console, messages be prefixed with custom strings. For example, run: `./mach run --setpref browser.uiCustomization.debug=true --jsconsole` and see the messages prefixed with "CustomizableUI:".

In this bug we'll need to add some stubs with a prefix, implement the frontend changes to render it, support filtering on the string, and write some tests (ideally in mocha tests with the stubs).

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1432232 - Implement prefix support in new console frontend; .

The prefix property was already on the packet, so all we had to
do was to support it. Which means:
 - retrieve the property in the packet and pass it to the message
 - when prefix exists, add a dom element with a custom style
 - search in prefix when filtering.

We add a couple of mocha tests with a stub packet to make sure we
handle those cases like we should.

Review commit: https://reviewboard.mozilla.org/r/222378/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/222378/

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8953123 [details]
Bug 1432232 - Implement prefix support in new console frontend; .

https://reviewboard.mozilla.org/r/222378/#review228316

Really nice!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8ffc9e58ff1
Implement prefix support in new console frontend; r=bgrins.

Comment 4

[Andreea Pavel [:apavel]]

Backed out for failing mochitest devtools failures at devtools/client/webconsole/new-console-output/test/fixtures/stub-generators/browser_webconsole_check_stubs_console_api.js

Push that contains the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=2e44a7285ccddce48e794db74ce59cd98fd1ae9f

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=163742100&repo=autoland&lineNumber=17303

Backout: https://hg.mozilla.org/integration/autoland/rev/fca4d1626c28bafb2764b7288522511f63aac98f

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/d8ffc9e58ff1

Comment 6

[Brian Grinstead [:bgrins]]

How did this hit m-c?  It was backed out on autoland in https://hg.mozilla.org/integration/autoland/rev/fca4d1626c28bafb2764b7288522511f63aac98f.

The changeset in autoland is marked as backed out https://hg.mozilla.org/integration/autoland/rev/d8ffc9e58ff1 but the backout doesn't appear in m-c: https://hg.mozilla.org/mozilla-central/rev/fca4d1626c28bafb2764b7288522511f63aac98f.

Comment 7

[Andrei Ciure[:aciure]]

We are aware of this issue and we will add the backout in the next merge.

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Sorry, hit the wrong button in mozreview

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8953123 [details]
Bug 1432232 - Implement prefix support in new console frontend; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/222378/diff/1-2/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58c8931ca290
Implement prefix support in new console frontend; r=bgrins.

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/58c8931ca290