1432271 - Remove TimeManager

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, enhancement, P3)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

TimeManager was an API implemented in FirefoxOS to set time on devices. It is no longer used, and can be removed.

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Bug 1432271 - Remove dom/time;

dom/time contained the TimeService and TimeManager classes, used for
setting time via Gecko on FirefoxOS. Since FirefoxOS is no longer in
the code base, the directory can be removed.

Review commit: https://reviewboard.mozilla.org/r/214728/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214728/

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Bug 1432271 - Remove MOZ_TIME_MANAGER block from old-configure.in;

Review commit: https://reviewboard.mozilla.org/r/214730/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214730/

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b8ad1366c4f34f2ba8eb167d628be2a65a3dcaea&selectedJob=157824219

Comment 4

[Andrea Marchesini [:baku]]

Comment on attachment 8944562 [details]
Bug 1432271 - Remove dom/time;

https://reviewboard.mozilla.org/r/214728/#review220432

Comment 6

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8944563 [details]
Bug 1432271 - Remove MOZ_TIME_MANAGER block from old-configure.in;

https://reviewboard.mozilla.org/r/214730/#review221100

lgtm.  Thanks for cleaning this stuff up!

Comment 7

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 7f6b3b518aaaef22e16c5a3cb0021d5e8e60aa9d -d 9218e87c25fb: rebasing 443945:7f6b3b518aaa "Bug 1432271 - Remove dom/time; r=baku"
merging dom/base/Navigator.cpp
merging dom/base/Navigator.h
merging dom/base/nsGlobalWindowInner.cpp
merging dom/base/nsGlobalWindowInner.h
merging dom/base/nsGlobalWindowOuter.cpp
merging dom/base/nsPIDOMWindow.h
merging dom/ipc/ContentChild.cpp
merging dom/ipc/ContentParent.cpp
merging dom/webidl/Navigator.webidl
merging layout/build/nsLayoutModule.cpp
merging layout/build/nsLayoutStatics.cpp
warning: conflicts while merging dom/base/Navigator.h! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 8

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8944562 [details]
Bug 1432271 - Remove dom/time;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214728/diff/1-2/

Comment 9

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8944563 [details]
Bug 1432271 - Remove MOZ_TIME_MANAGER block from old-configure.in;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214730/diff/1-2/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79b9d49e08db
Remove dom/time; r=baku
https://hg.mozilla.org/integration/autoland/rev/7af7827525c8
Remove MOZ_TIME_MANAGER block from old-configure.in; r=nalexander

Comment 11

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (bug 1432271) for bustage in /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/Navigator.h:79:23 on a CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=7af7827525c8188c0ba8bd3ba0dab16c778d3c12

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=158795882&repo=autoland

Backout: https://hg.mozilla.org/integration/autoland/rev/e7e552647dcbe9c7846fc99798e4f6bed3c7db79

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a117f844cf65
Remove dom/time; r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/939dd750a649
Remove MOZ_TIME_MANAGER block from old-configure.in; r=nalexander

Comment 13

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/a117f844cf65
https://hg.mozilla.org/mozilla-central/rev/939dd750a649