1432285 - Implement an nsPrintingPromptService::GetSingleton method and make XPCOM use it

Status: RESOLVED FIXED

(Core :: Printing: Setup, enhancement)

Description

[Jonathan Watt [:jwatt]]

All consumers of the XPCOM contract ID "@mozilla.org/embedcomp/printingprompt-service;1" obtain the nsIPrintingPromptService using do_GetService (or the JS equivalent CC.getService). None use do_GetInstance (or the JS equivalent). Consequently we only create one instance of nsPrintingPromptService per process, since do_GetService caches the first instance that it returns and then always returns that same object (see the entry->mServiceObject check in nsComponentManagerImpl::GetServiceByContractID).

Having internal C++ code get the concrete nsPrintingPromptService singleton instead of using do_GetService to obtain an nsIPrintingPromptService pointer will help clear the ground for some ownership refactoring I'm writing, without requiring awful hacks to the XPIDL.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: Bug 1432285 - Implement an nsPrintingPromptService::GetSingleton method and make XPCOM use that.

Review commit: https://reviewboard.mozilla.org/r/214702/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214702/

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: Bug 1432285 part 2 - Use nsPrintingPromptService::GetSingleton in internal code.

Review commit: https://reviewboard.mozilla.org/r/214704/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214704/

Comment 3

[Jonathan Watt [:jwatt]]

Of course this can't work given nsPrintingProxy...

I guess we can at least still land the first patch.

Comment 4

[Jonathan Watt [:jwatt]]

Comment on attachment 8944532 [details]
Bug 1432285 - Implement an nsPrintingPromptService::GetSingleton method and make XPCOM use that.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214702/diff/1-2/

Comment 5

[Bob Owen (:bobowen)]

Comment on attachment 8944532 [details]
Bug 1432285 - Implement an nsPrintingPromptService::GetSingleton method and make XPCOM use that.

https://reviewboard.mozilla.org/r/214702/#review220440

::: toolkit/components/printingui/nsPrintingPromptService.h:40
(Diff revision 2)
>    : public nsIPrintingPromptService
>    , public nsIWebProgressListener
>  {
>  
>  public:
> -  nsPrintingPromptService();
> +  static nsPrintingPromptService* GetSingleton();

I don't think we need this version any more.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/996706d59171
Implement an nsPrintingPromptService::GetSingleton method and make XPCOM use that. r=bobowen

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/996706d59171