1432293 - Switch Pocket "Now" card type to "Popular"

Status: RESOLVED WONTFIX

(Firefox :: New Tab Page, enhancement, P3)

Description

[Ed Lee :Mardak]

From https://github.com/mozilla/activity-stream/issues/3402

#3391 was a fix to just treat everything as Trending because we need a new string for "Popular".

uiwanted: Need to confirm string and icon

Comment 1

[Aaron Benson]

I think we ended up settling on keeping the trending context label with the lightning bolt. This is an old issue and should probably be taken up further with Pocket as we add experiments/features. I'm inclined to wontfix this for now, though.

Comment 2

[Ed Lee :Mardak]

nate, nick said you could answer the question of how we should display what used to be labeled "[clock] Now" cards, which right now is set by

const STORIES_NOW_THRESHOLD = 24 * 60 * 60 * 1000; // 24 hours
 "type": (Date.now() - (s.published_timestamp * 1000)) <= STORIES_NOW_THRESHOLD ? "now" : "trending",

but "now" and "trending" types currently both appear as "[bolt] Trending"

I believe this bug/issue was originally filed to make "now" type appear as "[bolt] Popular" ?

Comment 3

[Nate Weiner]

Ah, I forgot that we even had that behavior. IMHO right now we can just have the one "Trending" label, but if the Now behavior is in there, it's fine to leave in and then address when we iterate on these cards next.