Closed
Bug 1432314
Opened 7 years ago
Closed 7 years ago
Remove a FuncPtrCallTemp register definition that's currently defined in JS_CODEGEN_ARM but entirely unused
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: Waldo, Assigned: Waldo)
Details
Attachments
(1 file)
|
1.28 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
This is showing up as a build error on th for me in trypushes. I'm not sure why it wouldn't affect main th, but it's easy to fix.
It's somewhat worth noting there's another const Register just beneath this one, that uses the 2 register seemingly in concert with the 1 register here that I delete. Maybe that should change to 1, but I don't know this code nearly well enough to change that. I'm happy to change it if you know that change to be safe.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8944554 -
Flags: review?(jcoppeard)
|
||
Updated•7 years ago
|
Attachment #8944554 -
Flags: review?(jcoppeard) → review+
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6913a74f7632
Remove a FuncPtrCallTemp register definition that's currently defined in JS_CODEGEN_ARM but entirely unused. r=jonco
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•