Closed Bug 1432315 Opened 8 years ago Closed 7 years ago

Add tests for activity-stream.jsx

Categories

(Firefox :: New Tab Page, enhancement, P3)

Product:
Firefox
Component:
New Tab Page
Type:
enhancement

Tracking

()

Status:
RESOLVED WONTFIX
Tracking Flags:
Tracking Status
firefox60 --- wontfix

People

(Reporter: Mardak, Assigned: u594638, Mentored)

References

Details

(Keywords: good-first-bug)

From https://github.com/mozilla/activity-stream/issues/3373 Currently, we don't have any unit tests for content-src/activity-stream.jsx. We should add some. Hi @k88hudson - I've read the notes on Unit Testing in Activity Stream and I'm trying to figure out what tests I exactly need to carry out in the new test file (test/unit/activity-stream.test.jsx). I was reviewing activity-stream-prerender.test.jsx to get an idea of what's expected but I'm not sure exactly where to start. I think to start off, we should test to see if we're in a pre-rendered state. If not, then try to request "state rehydration" according to this comment and assert if we actually did get the expected outcome. What do you think? Would there be a better test suite that I should base my own off of?
Flags: needinfo?(khudson)
Let's revisit this when we add jsx test coverage
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(khudson)
Resolution: --- → WONTFIX
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.