Closed Bug 1432316 Opened 3 years ago Closed 3 years ago

Move a few ArrayBufferObjectMaybeShared inline member functions to the appropriate -inl.h file, after the *other* inline functions their definitions require

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: Waldo, Assigned: Waldo)

Details

Attachments

(1 file)

This causes errors in certain builds on th if I apply a patch to do |FILES_PER_UNIFIED_FILE = 1|.  Somehow this is *not* the same as nu builds (which do s/UNIFIED_SOURCES/SOURCES/g on the moz.builds).  Dunno why.  In any event, this seems like a footgun waiting to shoot us, and it's easily fixed.
<none>
Attached patch PatchSplinter Review
Attachment #8944555 - Flags: review?(sphink)
Comment on attachment 8944555 [details] [diff] [review]
Patch

Review of attachment 8944555 [details] [diff] [review]:
-----------------------------------------------------------------

Having SM(nu) pass and FILES_PER_UNIFIED_FILE=1 fail makes me unhappy. But r=me before I figure out what's going on there.
Attachment #8944555 - Flags: review?(sphink) → review+
FYI, it's *possible* that this patch plus the patch in bug 1432378 will fix the problem of FPUF=1 builds failing for used-but-not-defined + -Werror, so the symptoms of the "problem" in our build system will likely vanish soon.
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5bf428cf521
Move a few ArrayBufferObjectMaybeShared inline member functions to the appropriate -inl.h file, after the *other* inline functions their definitions require.  r=sfink
https://hg.mozilla.org/mozilla-central/rev/b5bf428cf521
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.