1432316 - Move a few ArrayBufferObjectMaybeShared inline member functions to the appropriate -inl.h file, after the *other* inline functions their definitions require

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Jeff Walden [:Waldo]]

This causes errors in certain builds on th if I apply a patch to do |FILES_PER_UNIFIED_FILE = 1|.  Somehow this is *not* the same as nu builds (which do s/UNIFIED_SOURCES/SOURCES/g on the moz.builds).  Dunno why.  In any event, this seems like a footgun waiting to shoot us, and it's easily fixed.
<none>

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Patch

Comment 2

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8944555 [details] [diff] [review]
Patch

Review of attachment 8944555 [details] [diff] [review]:
-----------------------------------------------------------------

Having SM(nu) pass and FILES_PER_UNIFIED_FILE=1 fail makes me unhappy. But r=me before I figure out what's going on there.

Comment 3

[Jeff Walden [:Waldo]]

FYI, it's *possible* that this patch plus the patch in bug 1432378 will fix the problem of FPUF=1 builds failing for used-but-not-defined + -Werror, so the symptoms of the "problem" in our build system will likely vanish soon.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5bf428cf521
Move a few ArrayBufferObjectMaybeShared inline member functions to the appropriate -inl.h file, after the *other* inline functions their definitions require.  r=sfink

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b5bf428cf521