1432331 - [flake8] Prevent external configuration from being picked up

Status: RESOLVED WONTFIX

(Developer Infrastructure :: Lint and Formatting, enhancement, P3)

Description

[Andrew Halberstadt [:ahal]]

If there is a global flake8 configuration, |mach lint -l flake8| will pick it up. This is bad because things will pass for developers locally, but potentially fail in CI. We should try to prevent external (outside of mozilla-central) configuration from being used.

Unfortunately flake8 makes this hard to do. There doesn't seem to be a way to provide multiple config files *and* ignore global ones. We can do one or the other, but not both. This leaves us with only two options that I can see:

1. Use a single global config file at the root of mozilla-central
2. Read the relevant configs outside of flake8, merge them, pass them back in as a single file

Option 1 means we can't have directory level config files (ironically, going this route would also allow us to switch flake8 to a blacklist instead of a whitelist). But it is a nice to have.

Option 2 seems like it would be do-able, but would add a decent amount of overhead and complexity.

Comment 1

[Mark Banner (:standard8)]

Flake8 is no longer used.