Closed Bug 1432338 Opened 4 years ago Closed 4 years ago

Introduce sync-brand.ftl

Categories

(Core :: Internationalization, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: zbraniecki, Assigned: zbraniecki)

References

Details

Attachments

(1 file)

On par with bug 1424683 (brand.ftl) we need syncBrand.ftl for bug 1424681.

Migration from: https://searchfox.org/mozilla-central/source/browser/locales/en-US/chrome/browser/syncBrand.dtd

I'm not sure if we should place it in browser or branding/.
Assignee: nobody → gandalf
Priority: -- → P3
I'd go for branding. Also, we'll need to spell out which of those brands are affected by which rules.
... should we put this into toolkit for android usage?
+1 on branding.

From a quick look, Android only uses syncBrand.shortName.label in the fake DTDs for Java (mobile/android/base/android_strings.dtd), not in the chrome part. Not sure if that affects the decision, personally I would leave Android out and only focus on desktop.
Are you guys suggesting `/branding/syncBrand.ftl` or `/browser/branding/syncBrand.ftl`?

Because I thought `/branding/syncBrand.ftl` but then I'm not sure what's the issue with android.
(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #4)
> Are you guys suggesting `/branding/syncBrand.ftl` or
> `/browser/branding/syncBrand.ftl`?
> 
> Because I thought `/branding/syncBrand.ftl` but then I'm not sure what's the
> issue with android.

Personally I was thinking browser/branding/syncBrand.ftl

I don't like the idea of a new root folder just for branding, assuming that's your suggestion with /branding/syncBrand.ftl
> I don't like the idea of a new root folder just for branding, assuming that's your suggestion with /branding/syncBrand.ftl

It wouldn't be a new folder - we use it in bug 1424683 for brand.ftl (and brand.dtd/properties).
(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #6)
> > I don't like the idea of a new root folder just for branding, assuming that's your suggestion with /branding/syncBrand.ftl
> 
> It wouldn't be a new folder - we use it in bug 1424683 for brand.ftl (and
> brand.dtd/properties).

Either we're talking about two different things, or I'm lost. 

Bug 1424683 has the file in 
/browser/branding/official/brand.ftl

I'm suggesting to have Sync brand in
/browser/branding/syncBrand.ftl

For reference, prefs.ftl is in
/browser/browser/preferences/preferences.ftl

With "root folder" I meant the repository's root, a folder at the same level as browser, dom, toolkit, etc. On the other hand, I think you mean "root" as "/browser" in the hg repository.
Blocks: 1435912
No longer blocks: 1424681
Several questions for :pike and :flod:

 - do we want brandSync.ftl or brand-sync.ftl?
 - does it make sense to add new FTL file for sync brands, or should we add a new message to brand.ftl (and potentially rename it to brands.ftl - for browser brands)?
Flags: needinfo?(l10n)
Flags: needinfo?(francesco.lodolo)
I would go with a separate file (brandSync.ftl), if nothing else because brands.ftl would end up containing elements with completely different policies (Firefox and Sync not localizable, Firefox Account localizable).

https://hg.mozilla.org/l10n/gecko-strings/file/default/browser/chrome/browser/syncBrand.dtd
Flags: needinfo?(francesco.lodolo)
I'd go for kebab-case for the file name. Mostly, because, nomnomkebab.
Flags: needinfo?(l10n)
Status: NEW → ASSIGNED
Summary: Introduce syncBrand.ftl → Introduce sync-brand.ftl
The patch looks good to me, but the migration doesn't work. Can you test that on your side?

If I change the destination file to 'browser/browser/preferences/preferences.ftl' it works, replacing the existing content. For a brand new file, even if already available in the repo, it doesn't work.

I'm trying to figure out what's causing it, because it seems like a bug in the migration code.
Depends on: 1437833
Comment on attachment 8950326 [details]
Bug 1432338 - Introduce sync-brand.ftl.

https://reviewboard.mozilla.org/r/219566/#review225568

::: python/l10n/fluent_migrations/bug_1432338_sync_brand.py:12
(Diff revision 2)
> +import fluent.syntax.ast as FTL
> +from fluent.migrate import COPY
> +
> +
> +def migrate(ctx):
> +    """Bug 1424683 - Introduce sync-brand.ftl, part {index}."""

Wrong bug number (bug 1432338)
Comment on attachment 8950326 [details]
Bug 1432338 - Introduce sync-brand.ftl.

r+ with the commit message fixed in migration
Attachment #8950326 - Flags: review?(francesco.lodolo) → review+
Comment on attachment 8950326 [details]
Bug 1432338 - Introduce sync-brand.ftl.

https://reviewboard.mozilla.org/r/219566/#review229662
Attachment #8950326 - Flags: review?(francesco.lodolo) → review+
https://hg.mozilla.org/mozilla-central/rev/a96df7af049c
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.