Closed
Bug 1432393
Opened 6 years ago
Closed 6 years ago
[MIPS64] Fix build issue due Bug 1421445
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: dragan.mladjenovic, Assigned: dragan.mladjenovic)
Details
Attachments
(1 file)
|
1.41 KB,
patch
|
jandem
:
review+
yuyin-hf
:
feedback+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.106 Safari/537.36
|
Assignee | |
Comment 1•6 years ago
|
||
This patch changes CodeAligment to 8 on both mips32 and mips64 jit targets matching what GCC already does for function entries on MIPS.
Attachment #8944651 -
Flags: feedback?(yuyin-hf)
Comment on attachment 8944651 [details] [diff] [review] bug1432393.patch Review of attachment 8944651 [details] [diff] [review]: ----------------------------------------------------------------- Yes, it should be 8. thank you.
Attachment #8944651 -
Flags: feedback?(yuyin-hf) → feedback+
|
|
Assignee | |
Updated•6 years ago
|
Attachment #8944651 -
Flags: review?(jdemooij)
|
||
Updated•6 years ago
|
Attachment #8944651 -
Flags: review?(jdemooij) → review+
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
|
||
Updated•6 years ago
|
Assignee: nobody → dragan.mladjenovic
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/de0952b4a0a2 [MIPS] Increase CodeAlignment to 8 bytes. r=jandem
Keywords: checkin-needed
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/de0952b4a0a2
Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•