Closed Bug 1432395 Opened 2 years ago Closed 2 years ago

Switch the valgrind build to a Debian-based docker image

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla60

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(4 files)

The valgrind build needs debug symbols installed for the system packages in order to be useful. This is better done in a separate image to make the one used for other builds smaller.

As with bug 1432392, we could just duplicate the debian7-amd64-build docker image and add cmake there, but since I'm close to make bug 1432390 a reality, I'd rather wait for that.
Blocks: 1432398
Depends on: 1433033
Comment on attachment 8945706 [details]
Bug 1432395 - Rename valgrind suppressions files to something more generic.

This is not enough. debian-security doesn't provide the data for apt-file, so libraries that come from there don't have debug symbols installed :(
Attachment #8945706 - Flags: review?(dustin)
Comment on attachment 8945987 [details]
Bug 1432395 - Switch the valgrind build to a Debian-based docker image.

https://reviewboard.mozilla.org/r/216046/#review222006
Attachment #8945987 - Flags: review?(dustin) → review+
Comment on attachment 8945706 [details]
Bug 1432395 - Rename valgrind suppressions files to something more generic.

https://reviewboard.mozilla.org/r/215824/#review222018
Attachment #8945706 - Flags: review?(nfroyd) → review+
Comment on attachment 8945986 [details]
Bug 1432395 - Add valgrind suppressions for system libraries on Debian.

https://reviewboard.mozilla.org/r/216044/#review222152
Attachment #8945986 - Flags: review+
Attachment #8945986 - Flags: review?(jseward)
Comment on attachment 8946457 [details]
Bug 1432395 - Change cache version to force new caches;

https://reviewboard.mozilla.org/r/216406/#review222182
Attachment #8946457 - Flags: review?(mh+mozilla) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/45aa598bf5b3
Rename valgrind suppressions files to something more generic. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/dd364d39f646
Add valgrind suppressions for system libraries on Debian. r=njn
https://hg.mozilla.org/integration/autoland/rev/3288fad489c1
Switch the valgrind build to a Debian-based docker image. r=dustin
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/52194341e149
Change cache version to force new caches; r=glandium
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.