1432395 - Switch the valgrind build to a Debian-based docker image

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Mike Hommey [:glandium]]

The valgrind build needs debug symbols installed for the system packages in order to be useful. This is better done in a separate image to make the one used for other builds smaller.

As with bug 1432392, we could just duplicate the debian7-amd64-build docker image and add cmake there, but since I'm close to make bug 1432390 a reality, I'd rather wait for that.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1432395 - Rename valgrind suppressions files to something more generic.

We start from the image used for Firefox builds, and add the debug
packages for all the system libraries.

Review commit: https://reviewboard.mozilla.org/r/215824/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/215824/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8945706 [details]
Bug 1432395 - Rename valgrind suppressions files to something more generic.

This is not enough. debian-security doesn't provide the data for apt-file, so libraries that come from there don't have debug symbols installed :(

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1432395 - Add valgrind suppressions for system libraries on Debian.

The first two are variants of existing ones, with a slightly different
signature, and tha last one is well known and found in glib-related
suppression files like https://github.com/flatpak/flatpak/blob/master/tests/glib.supp

Review commit: https://reviewboard.mozilla.org/r/216044/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216044/

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1432395 - Switch the valgrind build to a Debian-based docker image.

We start from the image used for Firefox builds, and add the debug
packages for all the system libraries.

Review commit: https://reviewboard.mozilla.org/r/216046/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216046/

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 8945706 [details]
Bug 1432395 - Rename valgrind suppressions files to something more generic.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/215824/diff/1-2/

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8945987 [details]
Bug 1432395 - Switch the valgrind build to a Debian-based docker image.

https://reviewboard.mozilla.org/r/216046/#review222006

Comment 7

[Nathan Froyd [:froydnj]]

Comment on attachment 8945706 [details]
Bug 1432395 - Rename valgrind suppressions files to something more generic.

https://reviewboard.mozilla.org/r/215824/#review222018

Comment 8

[Nicholas Nethercote [inactive]]

Comment on attachment 8945986 [details]
Bug 1432395 - Add valgrind suppressions for system libraries on Debian.

https://reviewboard.mozilla.org/r/216044/#review222152

Comment 9

[Gregory Szorc [:gps]]

Attachment: Bug 1432395 - Change cache version to force new caches;

This is basically the same deal as e331a3b9fae2. Caching is hard.

Review commit: https://reviewboard.mozilla.org/r/216406/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216406/

Comment 10

[Mike Hommey [:glandium]]

Comment on attachment 8946457 [details]
Bug 1432395 - Change cache version to force new caches;

https://reviewboard.mozilla.org/r/216406/#review222182

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45aa598bf5b3
Rename valgrind suppressions files to something more generic. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/dd364d39f646
Add valgrind suppressions for system libraries on Debian. r=njn
https://hg.mozilla.org/integration/autoland/rev/3288fad489c1
Switch the valgrind build to a Debian-based docker image. r=dustin

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52194341e149
Change cache version to force new caches; r=glandium

Comment 13

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/45aa598bf5b3
https://hg.mozilla.org/mozilla-central/rev/dd364d39f646
https://hg.mozilla.org/mozilla-central/rev/3288fad489c1
https://hg.mozilla.org/mozilla-central/rev/52194341e149