1432401 - Useless NS_ENSURE_TRUE in editor/libeditor/TextEditorDataTransfer.cpp

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P3)

Description

[Tooru Fujisawa [:arai]]

https://searchfox.org/mozilla-central/rev/b7e3ec2468d42fa59d86c03ec7afeb209813f1d4/editor/libeditor/TextEditorDataTransfer.cpp#185
>   nsCOMPtr<nsIDOMDocument> srcdomdoc;
>   if (sourceNode) {
>     sourceNode->GetOwnerDocument(getter_AddRefs(srcdomdoc));
>     NS_ENSURE_TRUE(sourceNode, NS_ERROR_FAILURE);

`NS_ENSURE_TRUE(sourceNode, NS_ERROR_FAILURE);` there is useless since it dereferences sourceNode in the previous line.

I guess it should check `srcdomdoc` instead?

Comment 1

[Videet Singhai]

hey I would like to work on this...can you tell me what to do exactly? (just remove 'NS_ENSURE_TRUE(sourceNode, NS_ERROR_FAILURE);')

Comment 2

[Tooru Fujisawa [:arai]]

(In reply to Videet Singhai from comment #1)
> hey I would like to work on this...can you tell me what to do exactly? (just
> remove 'NS_ENSURE_TRUE(sourceNode, NS_ERROR_FAILURE);')

I think, it's supposed to be checking srcdomdoc, instead of sourceNode.
So, replace sourceNode with srcdomdoc maybe?

Comment 3

[Videet Singhai]

I think in the latest build this bug is resolved, can u check?

Comment 4

[Tooru Fujisawa [:arai]]

oh, indeed.
thank you for your comment :)