Closed Bug 1432402 Opened 2 years ago Closed 2 years ago

Use :first-child instead of [first-tab] after removal in bug 480813

Categories

(Thunderbird :: Toolbars and Tabs, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 60.0

People

(Reporter: Paenglab, Assigned: Taraman)

Details

(Whiteboard: [Thunderbird-testfailure: Z all])

Attachments

(2 files)

Bug 480813 removed the [first-tab] attribute we used.
Attached patch first-tab.patchSplinter Review
I'm using now :first-child. I fixed also the left border of the first tab on Mac and Win 7 Aero and Win 8.

In https://dxr.mozilla.org/comm-central/source/calendar/test/mozmill/testTodayPane.js#133 we use also the "first-tab" but I don't know how to change this to the pseudo class. Jörg, please can you have a look and fix this test?
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8944655 - Flags: review?(jorgk)
That's calendar magic which I don't understand either :-(
Calendar people, can you please assist asap, since this will be causing test failures.
Flags: needinfo?(philipp)
Flags: needinfo?(makemyday)
Flags: needinfo?(Mozilla)
Keywords: leave-open
Comment on attachment 8944655 [details] [diff] [review]
first-tab.patch

Yes, left border on Win7 Aero fixed, otherwise no difference, working fine. Landing this now to avoid a bad Daily later.
Attachment #8944655 - Flags: review?(jorgk) → review+
https://hg.mozilla.org/comm-central/rev/89f273a5289ac4e3300db9f5ddfa8ccc72ebf7f2
Use :first-child instead of [first-tab] after removal in bug 480813. r=jorgk
As expected:
TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/testTodayPane.js | testTodayPane.js::testTodayPane
Whiteboard: [Thunderbird-testfailure: Z all]
Only failed on Linux and Mac??
Whiteboard: [Thunderbird-testfailure: Z all] → [Thunderbird-testfailure: Z Linux,Mac]
I'll have a as soon as build with this change is finished.
Flags: needinfo?(Mozilla)
Fails on Windows too, just not on TaskCluster(??).

Thanks Markus, not a huge problem.
Flags: needinfo?(philipp)
Flags: needinfo?(makemyday)
Whiteboard: [Thunderbird-testfailure: Z Linux,Mac] → [Thunderbird-testfailure: Z all]
As this tab is always the first one, we can just take [0] here to select the first tab.
Assignee: richard.marti → Mozilla
Attachment #8944776 - Flags: review?(makemyday)
Comment on attachment 8944776 [details] [diff] [review]
remove-first-tab.diff

I'm stealing this review. This looks very reasonable, thanks for the quick action, much appreciated.
Attachment #8944776 - Flags: review?(makemyday) → review+
Keywords: leave-open
Target Milestone: --- → Thunderbird 60.0
Oh, I also ran the test locally ;-)
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/49c4e7f78264
Use [0] to address the first tab after removal of "first-tab" in bug 480813. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.