1432412 - Re-implement browser_copy_folder_tree.js

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, enhancement, P2)

Description

[Mark Banner (:standard8)]

In bug 1131491 we removed browser_copy_folder_tree.js as it was using low-level functions like the old sync transactions.

We should re-implement it in a fashion where we're managing it at the UI level and checking the high-level user interactions are working correctly.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

the test was described as:
 Deep copy of bookmark data, using the front-end codepath:
 - create test folder A
 - add a subfolder to folder A, and add items to it
 - validate folder A (sanity check)
 - copy folder A into a new folder B
 - validate folder B
 - undo copy transaction
 - validate folder B (empty)
 - redo copy transaction
 - validate folder B's contents

We should do this simulating ui interactions in the Library

Comment 2

[Jane Kotovich (:janey)]

Hi Mak!
It seems like a very interesting one and I definitely would love to give it a go but I will probably;y need some navigation if you don't mind.
Thanks,
Jane

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I'm available on Matrix or feel free to Request information here or on Phabricator. Thanks.

Comment 4

[Jane Kotovich (:janey)]

Attachment: Bug 1432412 - Re-implement browser_copy_folder_tree.js. r=mak

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e39bb69595c
Re-implement browser_copy_folder_tree.js. r=mak

Comment 6

[Cosmin Sabou [:CosminS]]

Backed out for causing bc failures on browser_bookmark_copy_folder_tree.js and other tests.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&tochange=596dcada34488b71782ea1cf2e1c1ecb5dfb3dbb&fromchange=0e39bb69595c232ff2894f5562c21290f1748abb&searchStr=linux1804-64-tsan-qr%2Copt%2CMochitests%2Cwith%2Csoftware%2Cwebrender%2Cenabled%2Ctest-linux1804-64-tsan-qr%2Fopt-mochitest-browser-chrome-swr-e10s%2Cbc9&selectedTaskRun=FVLwJKaETEanMTDwIbPQrQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=356787637&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/596dcada34488b71782ea1cf2e1c1ecb5dfb3dbb

Comment 7

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

The screenshot looks as expected https://firefoxci.taskcluster-artifacts.net/FVLwJKaETEanMTDwIbPQrQ/0/public/test_info/mozilla-test-fail-screenshot_n60xsru8.png and this times out on a call to paste(). That's unexpected, especially since it only happens on Linux?
I'd suggest to reland with a skip-if on Linux and file a separate bug to figure out what's up there.

Comment 8

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

we're relanding with linux disabled and investigating it in a separate bug
Try https://treeherder.mozilla.org/jobs?repo=try&revision=de4a98f8547ec2b2d1e504558956d7408626df24

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2968b6922a0f
Re-implement browser_copy_folder_tree.js. r=mak

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/2968b6922a0f