1432425 - Refactor tests using removeFolderChildren

Status: RESOLVED FIXED

(Toolkit :: Places, enhancement, P2)

Description

[Marco Bonardo [:mak]]

Some of the tests are using removeFolderChildren, that in the new API doesn't exist. We should refactor those.
https://searchfox.org/mozilla-central/search?q=removeFolderChildren&path=

Comment 1

[Marco Bonardo [:mak]]

Attachment: Bug 1432425 - Remove synchronous Bookmarks::RemoveFolderChildren.

Review commit: https://reviewboard.mozilla.org/r/223124/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/223124/

Comment 2

[Marco Bonardo [:mak]]

Kit, could you please check that I didn't remove some important coverage from the Sync tests?

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8953968 [details]
Bug 1432425 - Remove synchronous Bookmarks::RemoveFolderChildren.

https://reviewboard.mozilla.org/r/223124/#review229062

Comment 4

[Lina Butler (ex-Mozilla)]

Comment on attachment 8953968 [details]
Bug 1432425 - Remove synchronous Bookmarks::RemoveFolderChildren.

https://reviewboard.mozilla.org/r/223124/#review229158

I have a suggestion to tweak the test, but it's up to you. Thanks!

::: services/sync/tests/unit/test_bookmark_tracker.js:428
(Diff revision 1)
>  
>    Assert.equal(createdIDs.length, numItems);
>    await verifyTrackedCount(numItems + 1); // the folder is also tracked.
>    await resetTracker();
>  
> -  PlacesUtils.bookmarks.removeFolderChildren(PlacesUtils.bookmarks.unfiledBookmarksFolder);
> +  await PlacesUtils.bookmarks.eraseEverything();

Since we already have `test_async_onItemDeleted_eraseEverything`, I'd prefer we change this test to create a folder with some bookmarks, call `PlacesUtils.bookmarks.remove(folderGuid)`, then verify we track the folder and all its children.

::: toolkit/components/places/tests/sync/xpcshell.ini:15
(Diff revision 1)
>  [test_bookmark_deletion.js]
>  [test_bookmark_haschanges.js]
>  [test_bookmark_kinds.js]
>  [test_bookmark_structure_changes.js]
>  [test_bookmark_value_changes.js]
> +[test_sync_utils.js]

Cool. :-)

Comment 5

[Marco Bonardo [:mak]]

Comment on attachment 8953968 [details]
Bug 1432425 - Remove synchronous Bookmarks::RemoveFolderChildren.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/223124/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/399e3160763a
Remove synchronous Bookmarks::RemoveFolderChildren. r=kitcambridge,standard8

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/399e3160763a