1432441 - XCUITests: Change suggested site label

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, enhancement)

Description

[Isabel Rios[:isabel_rios]]

XCUI Search Tests are failing because the suggested label used does not appear now.

- testDoNotShowSuggestionsWhenEnteringURL() 	Expect predicate exists == true for "foobar2000" Button 
- testPromptPresence() 	Expect predicate exists == true for "foobar2000" Button 	

Lets change it and use a different one.
This is one of the test affected:
https://github.com/mozilla-mobile/firefox-ios/blob/master/XCUITests/SearchTest.swift#L23

Before when entering foobar we expected "foobar2000" to appear.
Now we can use "foobar meaning" that seems more difficult to change.

These tests are failing in both master and v10.x. So once it is fixed in master we would need to uplift to v10.x branch.

Comment 1

[Isabel Rios[:isabel_rios]]

Attachment: Pull Request

Comment 2

[Isabel Rios[:isabel_rios]]

Comment on attachment 8944687 [details] [review]
Pull Request

Tests are green (the only red is due to the pdf failure which already has a bug open for fixing it)

https://dashboard.buddybuild.com/apps/57bf25c0f096bc01001e21e0/build/5a6720ccdd8f470001cbe67c#tests

Comment 3

[Isabel Rios[:isabel_rios]]

Merged on master: https://github.com/mozilla-mobile/firefox-ios/commit/cb1743ffe7a4457fcad9761d1285e74823eaeb70

Comment 4

[Isabel Rios[:isabel_rios]]

Uplifted to v10.x: https://github.com/mozilla-mobile/firefox-ios/commit/59062282c6d5576f3bebb78bb43bf612b28c03fd