Closed
Bug 1432448
Opened 6 years ago
Closed 6 years ago
buildbot script should check for word-only matches of FAILED to conclude failures
Categories
(NSS :: Test, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
3.36
People
(Reporter: KaiE, Assigned: KaiE)
Details
Attachments
(1 file)
|
660 bytes,
patch
|
franziskus
:
review+
|
Details | Diff | Splinter Review |
Currently, the build.sh script for buildbot decides about a failed build by using grep FAILED. This can have false positives, because the test logfile contains SSL error code names that include the term FAILED as part of their error code. It should be OK to change the code to use "grep -w", thereby excluding FAILED that occurs as a subset of other words.
|
Assignee | |
Comment 1•6 years ago
|
||
Assignee: nobody → kaie
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8944681 [details] [diff] [review] 1432448.patch Review of attachment 8944681 [details] [diff] [review]: ----------------------------------------------------------------- let's try this
Attachment #8944681 -
Flags: review+
|
|
Assignee | |
Comment 3•6 years ago
|
||
https://hg.mozilla.org/projects/nss/rev/c3702e37a048
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.36
You need to log in
before you can comment on or make changes to this bug.
Description
•