Remove the decimalplaces in notifications.xul after their removal in bug 1429625

RESOLVED FIXED in Thunderbird 60.0

Status

enhancement
RESOLVED FIXED
Last year
Last year

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 60.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

Last year
Bug 1429625 removes the decimalplaces in the numberboxes. We only use it in the prefs to set the time the new mail notification is shown.
Assignee

Comment 1

Last year
I tested this patch with a time set to 5.5 seconds and it showed 6 sec. Better longer than shorter.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8944709 - Flags: review?(jorgk)
Assignee

Comment 2

Last year
Ah, forgot to write that bug1429625 is in autoland.

Comment 3

Last year
Comment on attachment 8944709 [details] [diff] [review]
decimalplaces.patch

Untested, but looks reasonable (and I trust Swiss quality).
Attachment #8944709 - Flags: review?(jorgk) → review+
Assignee

Comment 4

Last year
Swiss quality like in the toolbar bindings bug? Hopefully not.
Keywords: checkin-needed

Comment 5

Last year
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/266495d41b73
Remove the decimalplaces in notifications.xul after their removal in bug 1429625. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: Last year
Keywords: checkin-needed
Resolution: --- → FIXED

Updated

Last year
Target Milestone: --- → Thunderbird 60.0
(In reply to Richard Marti (:Paenglab) from comment #1)
> Created attachment 8944709 [details] [diff] [review]
> decimalplaces.patch
> 
> I tested this patch with a time set to 5.5 seconds and it showed 6 sec.
> Better longer than shorter.

Yeah, bug 1429625 uses Math.round() which rounds 5.5 to 6.

Updated

Last year
Blocks: 1429625
You need to log in before you can comment on or make changes to this bug.