Closed Bug 1432462 Opened 6 years ago Closed 6 years ago

Remove the decimalplaces in notifications.xul after their removal in bug 1429625

Categories

(Thunderbird :: Preferences, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 60.0

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(1 file)

Bug 1429625 removes the decimalplaces in the numberboxes. We only use it in the prefs to set the time the new mail notification is shown.
I tested this patch with a time set to 5.5 seconds and it showed 6 sec. Better longer than shorter.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8944709 - Flags: review?(jorgk)
Ah, forgot to write that bug1429625 is in autoland.
Comment on attachment 8944709 [details] [diff] [review]
decimalplaces.patch

Untested, but looks reasonable (and I trust Swiss quality).
Attachment #8944709 - Flags: review?(jorgk) → review+
Swiss quality like in the toolbar bindings bug? Hopefully not.
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/266495d41b73
Remove the decimalplaces in notifications.xul after their removal in bug 1429625. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 60.0
(In reply to Richard Marti (:Paenglab) from comment #1)
> Created attachment 8944709 [details] [diff] [review]
> decimalplaces.patch
> 
> I tested this patch with a time set to 5.5 seconds and it showed 6 sec.
> Better longer than shorter.

Yeah, bug 1429625 uses Math.round() which rounds 5.5 to 6.
Blocks: 1429625
You need to log in before you can comment on or make changes to this bug.