1432468 - New XCUITest: Sync/FxAccount

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, enhancement)

Description

[Isabel Rios[:isabel_rios]]

Although we can not test yet the full flow from creating an account and sync it, we could add some tests to check some scenarios for example:

-User tries to sign in with wrong email/psw
-Check the UI for Sign in or Create account
-Try to sign in from settings or from last tour screen
-No presence of Disconnect Sync in settings
-...

Would that be useful till we can create more complete tests?

Comment 1

[Isabel Rios[:isabel_rios]]

Attachment: Pull Request

Comment 2

[Isabel Rios[:isabel_rios]]

There are a few things I'm not sure about on the FxScreenGraph. 

- Don't know how, if possible, to add identifiers for:
Sign in: app.webViews.buttons["Sign in"]
Create an account: app.webViews.links["Create an account"]

- Also I have changed the typePasscode function's name to make it more general so we can use it here when trying to type something.

I'm really bad naming stuff, so please feel free to suggest new names if they make more sense.

Comment 3

[No-Jun Park [:njpark]]

Comment on attachment 8946678 [details] [review]
Pull Request

Scriptwise, looks good to me except that I'd like to see the valid/invalid input texts at the script level, rather than looking into the FxScreengraph.

Comment 4

[Isabel Rios[:isabel_rios]]

Thanks No-Jun for your review and feedback! 
I did it that way to follow the approach similar to what we did for Authentication tests where user has to enter passcode and different scnearios (correct, incorrect passcode) are tested. 

I can change that and create Actions only to tap into the fields and use the typeText("whatever") after the actions in the test scripts so that it is clear what user is typing. Or I can add a comment to make it clear what user types and why is that the expected result and point to the place where it is set in case that is easier for future maintenance.

If you agree, lets wait for Jame's feedback and make a decision between the different approaches and what would be best for understanding and maintaining the tests.

Comment 5

[No-Jun Park [:njpark]]

Yeah I was thinking about Authentication tests too, for that we also embed passcodes, and ideally we'd like to get that exposed as well, but at least in that case it's a simple match/nonmatch comparison.  In this case, they might be wondering "what counts as 'invalid' input?" And since we're creating a new test and there's no need to touch the existing test case, this might be a good idea.

Comment 6

[James Hugman [:jhugman] [@jhugman]]

Comment on attachment 8946678 [details] [review]
Pull Request

I've left some comments in the PR. r? me again when you've made the requested changes. Thanks.

Comment 7

[Isabel Rios[:isabel_rios]]

Comment on attachment 8946678 [details] [review]
Pull Request

Thanks for the review! I addressed the comments on the PR and added more there. Hope it looks better and as you expected now.

Comment 8

[James Hugman [:jhugman] [@jhugman]]

Comment on attachment 8946678 [details] [review]
Pull Request

A couple of nits, but otherwise good job!

Comment 9

[Isabel Rios[:isabel_rios]]

Merged: https://github.com/mozilla-mobile/firefox-ios/commit/790c7bc87a7483cff4031c74786449c98941c17e

Comment 10

[Isabel Rios[:isabel_rios]]

Uplifted v11.x: https://github.com/mozilla-mobile/firefox-ios/commit/b18e69eb16abf99b79748f178176c1464d8bbed5